From: Al Viro <viro@zeniv.linux.org.uk>
To: Purva Yeshi <purvayeshi550@gmail.com>
Cc: Dave Kleikamp <shaggy@kernel.org>,
jfs-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
syzbot+219127d0a3bce650e1b6@syzkaller.appspotmail.com
Subject: Re: [PATCH] fs: jfs: Avoid sleeping function call in softirq
Date: Sat, 22 Mar 2025 14:35:49 +0000 [thread overview]
Message-ID: <20250322143549.GH2023217@ZenIV> (raw)
In-Reply-To: <20250322142134.35325-1-purvayeshi550@gmail.com>
On Sat, Mar 22, 2025 at 07:51:34PM +0530, Purva Yeshi wrote:
> Bug detected by Syzbot:
> BUG: sleeping function called from invalid context in jfs_fsync
>
> Fix jfs_fsync() to avoid sleeping in softirq/atomic, preventing crash.
> Skip execution in softirq/atomic and return -EWOULDBLOCK to prevent issues.
> Correct generic_file_fsync() call to pass the required arguments properly.
_ANY_ ->fsync() instance may sleep; adding that bandaid in jfs one does
not fix anything - the realy bug is whatever leads to having that
*called* in such conditions (e.g. having an unbalanced spin_lock()
somewhere, etc.)
NAK.
next prev parent reply other threads:[~2025-03-22 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-22 14:21 [PATCH] fs: jfs: Avoid sleeping function call in softirq Purva Yeshi
2025-03-22 14:35 ` Al Viro [this message]
2025-03-25 17:00 ` Purva Yeshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250322143549.GH2023217@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=purvayeshi550@gmail.com \
--cc=shaggy@kernel.org \
--cc=syzbot+219127d0a3bce650e1b6@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox