From: Willy Tarreau <w@1wt.eu>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
"Shuah Khan" <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
"Sebastian Andrzej Siewior" <sebastian@breakpoint.cc>
Subject: Re: [PATCH] selftests/nolibc: drop unnecessary sys/io.h include
Date: Sat, 29 Mar 2025 16:43:47 +0100 [thread overview]
Message-ID: <20250329154347.GA11338@1wt.eu> (raw)
In-Reply-To: <76eb91c8-4c66-4e2a-8d32-f2e5d545bb74@linuxfoundation.org>
On Fri, Mar 28, 2025 at 04:23:38PM -0600, Shuah Khan wrote:
> On 3/24/25 16:01, Thomas Weißschuh wrote:
> > The include of sys/io.h is not necessary anymore since
> > commit 67eb617a8e1e ("selftests/nolibc: simplify call to ioperm").
> > It's existence is also problematic as the header does not exist on all
> > architectures.
> >
> > Reported-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> > ---
> > tools/testing/selftests/nolibc/nolibc-test.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
> > index 5884a891c491544050fc35b07322c73a1a9dbaf3..7a60b6ac1457e8d862ab1a6a26c9e46abec92111 100644
> > --- a/tools/testing/selftests/nolibc/nolibc-test.c
> > +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> > @@ -16,7 +16,6 @@
> > #ifndef _NOLIBC_STDIO_H
> > /* standard libcs need more includes */
> > #include <sys/auxv.h>
> > -#include <sys/io.h>
> > #include <sys/ioctl.h>
> > #include <sys/mman.h>
> > #include <sys/mount.h>
> >
> > ---
> > base-commit: bceb73904c855c78402dca94c82915f078f259dd
> > change-id: 20250324-nolibc-ioperm-155646560b95
> >
> > Best regards,
>
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Fine for me as well.
Acked-by: Willy Tarreau <w@1wt.eu>
Thanks,
willy
prev parent reply other threads:[~2025-03-29 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 22:01 [PATCH] selftests/nolibc: drop unnecessary sys/io.h include Thomas Weißschuh
2025-03-28 22:23 ` Shuah Khan
2025-03-29 15:43 ` Willy Tarreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250329154347.GA11338@1wt.eu \
--to=w@1wt.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=sebastian@breakpoint.cc \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox