* [PATCH] selftests/nolibc: drop unnecessary sys/io.h include
@ 2025-03-24 22:01 Thomas Weißschuh
2025-03-28 22:23 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Weißschuh @ 2025-03-24 22:01 UTC (permalink / raw)
To: Willy Tarreau, Shuah Khan
Cc: linux-kselftest, linux-kernel, Sebastian Andrzej Siewior,
Thomas Weißschuh
The include of sys/io.h is not necessary anymore since
commit 67eb617a8e1e ("selftests/nolibc: simplify call to ioperm").
It's existence is also problematic as the header does not exist on all
architectures.
Reported-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
tools/testing/selftests/nolibc/nolibc-test.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
index 5884a891c491544050fc35b07322c73a1a9dbaf3..7a60b6ac1457e8d862ab1a6a26c9e46abec92111 100644
--- a/tools/testing/selftests/nolibc/nolibc-test.c
+++ b/tools/testing/selftests/nolibc/nolibc-test.c
@@ -16,7 +16,6 @@
#ifndef _NOLIBC_STDIO_H
/* standard libcs need more includes */
#include <sys/auxv.h>
-#include <sys/io.h>
#include <sys/ioctl.h>
#include <sys/mman.h>
#include <sys/mount.h>
---
base-commit: bceb73904c855c78402dca94c82915f078f259dd
change-id: 20250324-nolibc-ioperm-155646560b95
Best regards,
--
Thomas Weißschuh <linux@weissschuh.net>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] selftests/nolibc: drop unnecessary sys/io.h include
2025-03-24 22:01 [PATCH] selftests/nolibc: drop unnecessary sys/io.h include Thomas Weißschuh
@ 2025-03-28 22:23 ` Shuah Khan
2025-03-29 15:43 ` Willy Tarreau
0 siblings, 1 reply; 3+ messages in thread
From: Shuah Khan @ 2025-03-28 22:23 UTC (permalink / raw)
To: Thomas Weißschuh, Willy Tarreau, Shuah Khan
Cc: linux-kselftest, linux-kernel, Sebastian Andrzej Siewior,
Shuah Khan
On 3/24/25 16:01, Thomas Weißschuh wrote:
> The include of sys/io.h is not necessary anymore since
> commit 67eb617a8e1e ("selftests/nolibc: simplify call to ioperm").
> It's existence is also problematic as the header does not exist on all
> architectures.
>
> Reported-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> tools/testing/selftests/nolibc/nolibc-test.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
> index 5884a891c491544050fc35b07322c73a1a9dbaf3..7a60b6ac1457e8d862ab1a6a26c9e46abec92111 100644
> --- a/tools/testing/selftests/nolibc/nolibc-test.c
> +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> @@ -16,7 +16,6 @@
> #ifndef _NOLIBC_STDIO_H
> /* standard libcs need more includes */
> #include <sys/auxv.h>
> -#include <sys/io.h>
> #include <sys/ioctl.h>
> #include <sys/mman.h>
> #include <sys/mount.h>
>
> ---
> base-commit: bceb73904c855c78402dca94c82915f078f259dd
> change-id: 20250324-nolibc-ioperm-155646560b95
>
> Best regards,
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] selftests/nolibc: drop unnecessary sys/io.h include
2025-03-28 22:23 ` Shuah Khan
@ 2025-03-29 15:43 ` Willy Tarreau
0 siblings, 0 replies; 3+ messages in thread
From: Willy Tarreau @ 2025-03-29 15:43 UTC (permalink / raw)
To: Shuah Khan
Cc: Thomas Weißschuh, Shuah Khan, linux-kselftest, linux-kernel,
Sebastian Andrzej Siewior
On Fri, Mar 28, 2025 at 04:23:38PM -0600, Shuah Khan wrote:
> On 3/24/25 16:01, Thomas Weißschuh wrote:
> > The include of sys/io.h is not necessary anymore since
> > commit 67eb617a8e1e ("selftests/nolibc: simplify call to ioperm").
> > It's existence is also problematic as the header does not exist on all
> > architectures.
> >
> > Reported-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> > ---
> > tools/testing/selftests/nolibc/nolibc-test.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
> > index 5884a891c491544050fc35b07322c73a1a9dbaf3..7a60b6ac1457e8d862ab1a6a26c9e46abec92111 100644
> > --- a/tools/testing/selftests/nolibc/nolibc-test.c
> > +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> > @@ -16,7 +16,6 @@
> > #ifndef _NOLIBC_STDIO_H
> > /* standard libcs need more includes */
> > #include <sys/auxv.h>
> > -#include <sys/io.h>
> > #include <sys/ioctl.h>
> > #include <sys/mman.h>
> > #include <sys/mount.h>
> >
> > ---
> > base-commit: bceb73904c855c78402dca94c82915f078f259dd
> > change-id: 20250324-nolibc-ioperm-155646560b95
> >
> > Best regards,
>
> Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Fine for me as well.
Acked-by: Willy Tarreau <w@1wt.eu>
Thanks,
willy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-29 15:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-24 22:01 [PATCH] selftests/nolibc: drop unnecessary sys/io.h include Thomas Weißschuh
2025-03-28 22:23 ` Shuah Khan
2025-03-29 15:43 ` Willy Tarreau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox