From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mika Westerberg <westeri@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v2 0/6] gpiolib: acpi: Refactor to shrink the code by ~8%
Date: Fri, 4 Apr 2025 07:43:18 +0300 [thread overview]
Message-ID: <20250404044318.GL3152277@black.fi.intel.com> (raw)
In-Reply-To: <20250403160034.2680485-1-andriy.shevchenko@linux.intel.com>
On Thu, Apr 03, 2025 at 06:59:11PM +0300, Andy Shevchenko wrote:
> A simple refactoring of the GPIO ACPI library parts to get an impressive
> ~8% code shrink on x86_64 and ~2% on x86_32. Also reduces a C code a bit.
>
> add/remove: 0/2 grow/shrink: 0/5 up/down: 0/-1221 (-1221)
> Function old new delta
> acpi_gpio_property_lookup 425 414 -11
> acpi_find_gpio.__UNIQUE_ID_ddebug478 56 - -56
> acpi_dev_gpio_irq_wake_get_by.__UNIQUE_ID_ddebug480 56 - -56
> acpi_find_gpio 354 216 -138
> acpi_get_gpiod_by_index 462 307 -155
> __acpi_find_gpio 877 638 -239
> acpi_dev_gpio_irq_wake_get_by 695 129 -566
> Total: Before=15375, After=14154, chg -7.94%
>
> In v2:
> - renamed par to params (Mika, Bart)
>
> Andy Shevchenko (6):
> gpiolib: acpi: Improve struct acpi_gpio_info memory footprint
> gpiolib: acpi: Remove index parameter from acpi_gpio_property_lookup()
> gpiolib: acpi: Reduce memory footprint for struct acpi_gpio_params
> gpiolib: acpi: Rename par to params for better readability
> gpiolib: acpi: Reuse struct acpi_gpio_params in struct
> acpi_gpio_lookup
> gpiolib: acpi: Deduplicate some code in __acpi_find_gpio()
Looks good now,
Acked-by: Mika Westerberg <westeri@kernel.org>
next prev parent reply other threads:[~2025-04-04 4:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 15:59 [PATCH v2 0/6] gpiolib: acpi: Refactor to shrink the code by ~8% Andy Shevchenko
2025-04-03 15:59 ` [PATCH v2 1/6] gpiolib: acpi: Improve struct acpi_gpio_info memory footprint Andy Shevchenko
2025-04-03 15:59 ` [PATCH v2 2/6] gpiolib: acpi: Remove index parameter from acpi_gpio_property_lookup() Andy Shevchenko
2025-04-03 15:59 ` [PATCH v2 3/6] gpiolib: acpi: Reduce memory footprint for struct acpi_gpio_params Andy Shevchenko
2025-04-03 15:59 ` [PATCH v2 4/6] gpiolib: acpi: Rename par to params for better readability Andy Shevchenko
2025-04-03 15:59 ` [PATCH v2 5/6] gpiolib: acpi: Reuse struct acpi_gpio_params in struct acpi_gpio_lookup Andy Shevchenko
2025-04-03 15:59 ` [PATCH v2 6/6] gpiolib: acpi: Deduplicate some code in __acpi_find_gpio() Andy Shevchenko
2025-04-08 20:09 ` Kees Bakker
2025-04-09 7:31 ` Andy Shevchenko
2025-04-04 4:43 ` Mika Westerberg [this message]
2025-04-07 6:41 ` [PATCH v2 0/6] gpiolib: acpi: Refactor to shrink the code by ~8% Andy Shevchenko
2025-04-04 8:38 ` Bartosz Golaszewski
2025-04-04 10:23 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250404044318.GL3152277@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox