From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kees Bakker <kees@ijzerbout.nl>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mika Westerberg <westeri@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v2 6/6] gpiolib: acpi: Deduplicate some code in __acpi_find_gpio()
Date: Wed, 9 Apr 2025 10:31:11 +0300 [thread overview]
Message-ID: <Z_YiP91I9ojNnOi4@smile.fi.intel.com> (raw)
In-Reply-To: <9715c8dd-38df-48fd-a9d1-7a78163dc989@ijzerbout.nl>
On Tue, Apr 08, 2025 at 10:09:25PM +0200, Kees Bakker wrote:
> Op 03-04-2025 om 17:59 schreef Andy Shevchenko:
...
> Please, check the changes in this function again.
> `__acpi_find_gpio` doesn't fill `info` anymore. The callers of this function
> will continue with
> an uninitialized struct.
My gosh, you are so right! Now I'm puzzled of what I was tested...
Nevertheless, I will fix this ASAP today, test (and double test to
be sure it works), and push it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-09 7:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 15:59 [PATCH v2 0/6] gpiolib: acpi: Refactor to shrink the code by ~8% Andy Shevchenko
2025-04-03 15:59 ` [PATCH v2 1/6] gpiolib: acpi: Improve struct acpi_gpio_info memory footprint Andy Shevchenko
2025-04-03 15:59 ` [PATCH v2 2/6] gpiolib: acpi: Remove index parameter from acpi_gpio_property_lookup() Andy Shevchenko
2025-04-03 15:59 ` [PATCH v2 3/6] gpiolib: acpi: Reduce memory footprint for struct acpi_gpio_params Andy Shevchenko
2025-04-03 15:59 ` [PATCH v2 4/6] gpiolib: acpi: Rename par to params for better readability Andy Shevchenko
2025-04-03 15:59 ` [PATCH v2 5/6] gpiolib: acpi: Reuse struct acpi_gpio_params in struct acpi_gpio_lookup Andy Shevchenko
2025-04-03 15:59 ` [PATCH v2 6/6] gpiolib: acpi: Deduplicate some code in __acpi_find_gpio() Andy Shevchenko
2025-04-08 20:09 ` Kees Bakker
2025-04-09 7:31 ` Andy Shevchenko [this message]
2025-04-04 4:43 ` [PATCH v2 0/6] gpiolib: acpi: Refactor to shrink the code by ~8% Mika Westerberg
2025-04-07 6:41 ` Andy Shevchenko
2025-04-04 8:38 ` Bartosz Golaszewski
2025-04-04 10:23 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_YiP91I9ojNnOi4@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=kees@ijzerbout.nl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox