[PATCH] init/Kconfig: conditionalize GCC10_NO_ARRAY_BOUNDS

[PATCH] init/Kconfig: conditionalize GCC10_NO_ARRAY_BOUNDS

[Shyam Saini]

GCC10_NO_ARRAY_BOUNDS is a GCC option and should only be enabled
if CC is GCC.

Signed-off-by: Shyam Saini <shyamsaini@linux.microsoft.com>
---
 init/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/init/Kconfig b/init/Kconfig
index c1f9eb3d5f2e8..52bb1419d6c0e 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -905,7 +905,7 @@ config CC_IMPLICIT_FALLTHROUGH
 # Currently, disable gcc-10+ array-bounds globally.
 # It's still broken in gcc-13, so no upper bound yet.
 config GCC10_NO_ARRAY_BOUNDS
-	def_bool y
+	def_bool y if CC_IS_GCC
 
 config CC_NO_ARRAY_BOUNDS
 	bool

base-commit: e25c8d66f6786300b680866c0e0139981273feba
-- 
2.34.1

[PATCH] init/Kconfig: conditionalize GCC10_NO_ARRAY_BOUNDS

[Shyam Saini]

Hi Masahiro,

Do you have any feedback or reviews on this patch ?
Please let me know.

Thanks,
Shyam

[PATCH] init/Kconfig: conditionalize GCC10_NO_ARRAY_BOUNDS

[Shyam Saini]

Hi Masahiro, Kees

do you have any reviews for this patch?

Thanks,
Shyam


  git send-email \
    --in-reply-to=20250211221030.1815731-1-shyamsaini@linux.microsoft.com \
    --to=masahiroy@kernel.org \
    --to=kees@kernel.org \
    --cc=shyamsaini@linux.microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    /tmp/reply-kconfig-init

Re: [PATCH] init/Kconfig: conditionalize GCC10_NO_ARRAY_BOUNDS

[Kees Cook]

On Thu, Mar 27, 2025 at 11:35:59AM -0700, Shyam Saini wrote:
> do you have any reviews for this patch?

It's a redundant change since CC_IS_GCC is checked later:

config GCC10_NO_ARRAY_BOUNDS
        def_bool y

config CC_NO_ARRAY_BOUNDS
        bool
        default y if CC_IS_GCC && GCC_VERSION >= 90000 && GCC10_NO_ARRAY_BOUNDS


If you wanted to make this change, then it would make sense to drop it
from CC_NO_ARRAY_BOUNDS at the same time.

-Kees

-- 
Kees Cook