* [PATCH] media: qcom: camss: vfe: suppress VFE version log spam
@ 2025-04-07 7:31 Johan Hovold
2025-04-07 8:18 ` Bryan O'Donoghue
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2025-04-07 7:31 UTC (permalink / raw)
To: Robert Foss, Todor Tomov, Bryan ODonoghue, Mauro Carvalho Chehab
Cc: Hans Verkuil, linux-media, linux-arm-msm, linux-kernel,
Johan Hovold, Depeng Shao
A recent commit refactored the printing of the VFE hardware version, but
(without it being mentioned) also changed the log level from debug to
info.
This results in several hundred lines of repeated log spam during boot
and use, for example, on the Lenovo ThinkPad X13s:
qcom-camss ac5a000.camss: VFE:1 HW Version = 1.2.2
qcom-camss ac5a000.camss: VFE:0 HW Version = 1.2.2
qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2
qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2
qcom-camss ac5a000.camss: VFE:3 HW Version = 1.2.2
qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0
qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0
qcom-camss ac5a000.camss: VFE:4 HW Version = 1.3.0
qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0
qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0
qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0
qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0
qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0
...
Suppress the version logging by demoting to debug level again.
Cc: Depeng Shao <quic_depengs@quicinc.com>
Fixes: 10693fed125d ("media: qcom: camss: vfe: Move common code into vfe core")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/media/platform/qcom/camss/camss-vfe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
index cf0e8f5c004a..1ed2518c7a6b 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe.c
@@ -428,7 +428,7 @@ u32 vfe_hw_version(struct vfe_device *vfe)
u32 rev = (hw_version >> HW_VERSION_REVISION) & 0xFFF;
u32 step = (hw_version >> HW_VERSION_STEPPING) & 0xFFFF;
- dev_info(vfe->camss->dev, "VFE:%d HW Version = %u.%u.%u\n",
+ dev_dbg(vfe->camss->dev, "VFE:%d HW Version = %u.%u.%u\n",
vfe->id, gen, rev, step);
return hw_version;
--
2.49.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media: qcom: camss: vfe: suppress VFE version log spam
2025-04-07 7:31 [PATCH] media: qcom: camss: vfe: suppress VFE version log spam Johan Hovold
@ 2025-04-07 8:18 ` Bryan O'Donoghue
0 siblings, 0 replies; 2+ messages in thread
From: Bryan O'Donoghue @ 2025-04-07 8:18 UTC (permalink / raw)
To: Johan Hovold, Robert Foss, Todor Tomov, Mauro Carvalho Chehab
Cc: Hans Verkuil, linux-media, linux-arm-msm, linux-kernel,
Depeng Shao
On 07/04/2025 08:31, Johan Hovold wrote:
> A recent commit refactored the printing of the VFE hardware version, but
> (without it being mentioned) also changed the log level from debug to
> info.
>
> This results in several hundred lines of repeated log spam during boot
> and use, for example, on the Lenovo ThinkPad X13s:
>
> qcom-camss ac5a000.camss: VFE:1 HW Version = 1.2.2
> qcom-camss ac5a000.camss: VFE:0 HW Version = 1.2.2
> qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2
> qcom-camss ac5a000.camss: VFE:2 HW Version = 1.2.2
> qcom-camss ac5a000.camss: VFE:3 HW Version = 1.2.2
> qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0
> qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0
> qcom-camss ac5a000.camss: VFE:4 HW Version = 1.3.0
> qcom-camss ac5a000.camss: VFE:5 HW Version = 1.3.0
> qcom-camss ac5a000.camss: VFE:6 HW Version = 1.3.0
> qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0
> qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0
> qcom-camss ac5a000.camss: VFE:7 HW Version = 1.3.0
> ...
>
> Suppress the version logging by demoting to debug level again.
>
> Cc: Depeng Shao <quic_depengs@quicinc.com>
> Fixes: 10693fed125d ("media: qcom: camss: vfe: Move common code into vfe core")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> drivers/media/platform/qcom/camss/camss-vfe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> index cf0e8f5c004a..1ed2518c7a6b 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -428,7 +428,7 @@ u32 vfe_hw_version(struct vfe_device *vfe)
> u32 rev = (hw_version >> HW_VERSION_REVISION) & 0xFFF;
> u32 step = (hw_version >> HW_VERSION_STEPPING) & 0xFFFF;
>
> - dev_info(vfe->camss->dev, "VFE:%d HW Version = %u.%u.%u\n",
> + dev_dbg(vfe->camss->dev, "VFE:%d HW Version = %u.%u.%u\n",
> vfe->id, gen, rev, step);
>
> return hw_version;
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-07 8:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-07 7:31 [PATCH] media: qcom: camss: vfe: suppress VFE version log spam Johan Hovold
2025-04-07 8:18 ` Bryan O'Donoghue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox