From: Francesco Dolcini <francesco@dolcini.it>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 1/4] wifi: mwifiex: remove unnecessary queue empty check
Date: Fri, 11 Apr 2025 09:41:44 +0200 [thread overview]
Message-ID: <20250411074144.GA12707@francesco-nb> (raw)
In-Reply-To: <20250410-mwifiex-drop-asynchronous-init-v1-1-6a212fa9185e@pengutronix.de>
On Thu, Apr 10, 2025 at 12:28:43PM +0200, Sascha Hauer wrote:
> Since 7bff9c974e1a ("mwifiex: send firmware initialization commands
> synchronously") all initialization commands are sent synchronously which
> means the command queue is empty when mwifiex_sta_init_cmd() returns. No
> need to check for entries in the command code then, so remove the check.
>
> Add a WARN_ON() just in case there is something wrong with the
> reasoning.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
next prev parent reply other threads:[~2025-04-11 7:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 10:28 [PATCH 0/4] wifi: mwifiex: drop asynchronous init waiting code Sascha Hauer
2025-04-10 10:28 ` [PATCH 1/4] wifi: mwifiex: remove unnecessary queue empty check Sascha Hauer
2025-04-11 7:41 ` Francesco Dolcini [this message]
2025-04-10 10:28 ` [PATCH 2/4] wifi: mwifiex: let mwifiex_init_fw() return 0 for success Sascha Hauer
2025-04-11 7:58 ` Francesco Dolcini
2025-04-10 10:28 ` [PATCH 3/4] wifi: mwifiex: drop asynchronous init waiting code Sascha Hauer
2025-04-11 6:49 ` Sascha Hauer
2025-04-11 8:49 ` Francesco Dolcini
2025-04-11 12:57 ` Sascha Hauer
2025-04-10 10:28 ` [PATCH 4/4] wifi: mwifiex: remove mwifiex_sta_init_cmd() last argument Sascha Hauer
2025-04-11 8:51 ` Francesco Dolcini
2025-04-22 0:17 ` [PATCH 0/4] wifi: mwifiex: drop asynchronous init waiting code Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250411074144.GA12707@francesco-nb \
--to=francesco@dolcini.it \
--cc=briannorris@chromium.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox