[PATCH] rbtree: Fix typo in header comment

[PATCH] rbtree: Fix typo in header comment

[Po-Ying Chiu]

Correct "drammatically" to "dramatically" in the rbtree.h header comment.
This improves the readability of the header comment.

Signed-off-by: Po-Ying Chiu <charlie910417@gmail.com>
---
 include/linux/rbtree.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/rbtree.h b/include/linux/rbtree.h
index 8d2ba3749866..78a7a260c36f 100644
--- a/include/linux/rbtree.h
+++ b/include/linux/rbtree.h
@@ -7,7 +7,7 @@
   linux/include/linux/rbtree.h
 
   To use rbtrees you'll have to implement your own insert and search cores.
-  This will avoid us to use callbacks and to drop drammatically performances.
+  This will avoid us to use callbacks and to drop dramatically performances.
   I know it's not the cleaner way,  but in C (not in C++) to get
   performances and genericity...
 

base-commit: 2eb959eeecc64fa56e9f89a5fc496da297585cbe
-- 
2.43.0

Re: [PATCH] rbtree: Fix typo in header comment

[David Sterba]

On Sat, Apr 12, 2025 at 09:55:16AM +0800, Po-Ying Chiu wrote:
> Correct "drammatically" to "dramatically" in the rbtree.h header comment.
> This improves the readability of the header comment.
> 
> Signed-off-by: Po-Ying Chiu <charlie910417@gmail.com>
> ---
>  include/linux/rbtree.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/rbtree.h b/include/linux/rbtree.h
> index 8d2ba3749866..78a7a260c36f 100644
> --- a/include/linux/rbtree.h
> +++ b/include/linux/rbtree.h
> @@ -7,7 +7,7 @@
>    linux/include/linux/rbtree.h
>  
>    To use rbtrees you'll have to implement your own insert and search cores.
> -  This will avoid us to use callbacks and to drop drammatically performances.
> +  This will avoid us to use callbacks and to drop dramatically performances.
>    I know it's not the cleaner way,  but in C (not in C++) to get
>    performances and genericity...

Maybe the paragraph can be rephrased entierely, "drop dramatically
performances" does not sound right to me.

[PATCH v2] rbtree: Fix typo in header comment

[Po-Ying Chiu]

Correct "drammatically" to "dramatically" in the rbtree.h header comment.
This improves the readability of the header comment.

Signed-off-by: Po-Ying Chiu <charlie910417@gmail.com>
---
Changes since v1:
* Rephrased the whole paragraph to imporve readability.

 include/linux/rbtree.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/rbtree.h b/include/linux/rbtree.h
index 8d2ba3749866..02b6733cce55 100644
--- a/include/linux/rbtree.h
+++ b/include/linux/rbtree.h
@@ -6,10 +6,10 @@
 
   linux/include/linux/rbtree.h
 
-  To use rbtrees you'll have to implement your own insert and search cores.
-  This will avoid us to use callbacks and to drop drammatically performances.
-  I know it's not the cleaner way,  but in C (not in C++) to get
-  performances and genericity...
+  To use rbtrees, you'll have to implement your own insert and search cores.
+  This avoids the need for callbacks, which would otherwise significantly reduce performance.
+  It may not be the cleanest approach, but in C (as opposed to C++), it is often
+  necessary to achieve both performance and genericity.
 
   See Documentation/core-api/rbtree.rst for documentation and samples.
 */
-- 
2.43.0