[PATCH] s390/crc32: Remove no-op module init and exit functions

[PATCH] s390/crc32: Remove no-op module init and exit functions

[Eric Biggers]

From: Eric Biggers <ebiggers@google.com>

Now that the crc32-s390 module init function is a no-op, there is no
need to define it.  Remove it.  The removal of the init function also
makes the exit function unnecessary, so remove that too.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---

I'll take this via the crc tree.

 arch/s390/lib/crc32-glue.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/arch/s390/lib/crc32-glue.c b/arch/s390/lib/crc32-glue.c
index 649ed7e8b99c..3c4b344417c1 100644
--- a/arch/s390/lib/crc32-glue.c
+++ b/arch/s390/lib/crc32-glue.c
@@ -59,21 +59,10 @@
 
 DEFINE_CRC32_VX(crc32_le_arch, crc32_le_vgfm_16, crc32_le_base)
 DEFINE_CRC32_VX(crc32_be_arch, crc32_be_vgfm_16, crc32_be_base)
 DEFINE_CRC32_VX(crc32c_arch, crc32c_le_vgfm_16, crc32c_base)
 
-static int __init crc32_s390_init(void)
-{
-	return 0;
-}
-arch_initcall(crc32_s390_init);
-
-static void __exit crc32_s390_exit(void)
-{
-}
-module_exit(crc32_s390_exit);
-
 u32 crc32_optimizations(void)
 {
 	if (cpu_has_vx()) {
 		return CRC32_LE_OPTIMIZATION |
 		       CRC32_BE_OPTIMIZATION |

base-commit: 34a3ebfb22d694cc07addae5ce0a8f83139592bd
-- 
2.49.0

Re: [PATCH] s390/crc32: Remove no-op module init and exit functions

[Heiko Carstens]

On Thu, Apr 17, 2025 at 09:38:29AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> Now that the crc32-s390 module init function is a no-op, there is no
> need to define it.  Remove it.  The removal of the init function also
> makes the exit function unnecessary, so remove that too.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> 
> I'll take this via the crc tree.
> 
>  arch/s390/lib/crc32-glue.c | 11 -----------
>  1 file changed, 11 deletions(-)

Acked-by: Heiko Carstens <hca@linux.ibm.com>