* [PATCH] drm/rockchip: add CONFIG_OF dependency
@ 2025-04-23 16:44 Arnd Bergmann
2025-04-23 17:18 ` Dmitry Baryshkov
2025-05-01 11:03 ` Heiko Stuebner
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2025-04-23 16:44 UTC (permalink / raw)
To: Sandy Huang, Heiko Stübner, Andy Yan, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Dmitry Baryshkov, Douglas Anderson, Damon Ding
Cc: Arnd Bergmann, Heiko Stuebner, Geert Uytterhoeven,
Cristian Ciocaltea, dri-devel, linux-arm-kernel, linux-rockchip,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
DRM_DISPLAY_DP_AUX_BUS cannot be selected when CONFIG_OF is disabled:
WARNING: unmet direct dependencies detected for DRM_DISPLAY_DP_AUX_BUS
Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n]
Selected by [y]:
- DRM_ROCKCHIP [=y] && HAS_IOMEM [=y] && DRM [=y] && ROCKCHIP_IOMMU [=y] && ROCKCHIP_ANALOGIX_DP [=y]
Rockchip platforms all depend on OF anyway, so add the dependency here
for compile testing.
Fixes: d7b4936b2bc0 ("drm/rockchip: analogix_dp: Add support to get panel from the DP AUX bus")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/rockchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
index caa251f91dd8..6b9f43c05148 100644
--- a/drivers/gpu/drm/rockchip/Kconfig
+++ b/drivers/gpu/drm/rockchip/Kconfig
@@ -2,6 +2,7 @@
config DRM_ROCKCHIP
tristate "DRM Support for Rockchip"
depends on DRM && ROCKCHIP_IOMMU
+ depends on OF
select DRM_CLIENT_SELECTION
select DRM_GEM_DMA_HELPER
select DRM_KMS_HELPER
--
2.39.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/rockchip: add CONFIG_OF dependency
2025-04-23 16:44 [PATCH] drm/rockchip: add CONFIG_OF dependency Arnd Bergmann
@ 2025-04-23 17:18 ` Dmitry Baryshkov
2025-04-24 0:42 ` Andy Yan
2025-05-01 11:03 ` Heiko Stuebner
1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-04-23 17:18 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Sandy Huang, Heiko Stübner, Andy Yan, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Dmitry Baryshkov, Douglas Anderson, Damon Ding, Arnd Bergmann,
Heiko Stuebner, Geert Uytterhoeven, Cristian Ciocaltea, dri-devel,
linux-arm-kernel, linux-rockchip, linux-kernel
On Wed, Apr 23, 2025 at 06:44:16PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> DRM_DISPLAY_DP_AUX_BUS cannot be selected when CONFIG_OF is disabled:
>
> WARNING: unmet direct dependencies detected for DRM_DISPLAY_DP_AUX_BUS
> Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n]
> Selected by [y]:
> - DRM_ROCKCHIP [=y] && HAS_IOMEM [=y] && DRM [=y] && ROCKCHIP_IOMMU [=y] && ROCKCHIP_ANALOGIX_DP [=y]
>
> Rockchip platforms all depend on OF anyway, so add the dependency here
> for compile testing.
>
> Fixes: d7b4936b2bc0 ("drm/rockchip: analogix_dp: Add support to get panel from the DP AUX bus")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re:Re: [PATCH] drm/rockchip: add CONFIG_OF dependency
2025-04-23 17:18 ` Dmitry Baryshkov
@ 2025-04-24 0:42 ` Andy Yan
0 siblings, 0 replies; 4+ messages in thread
From: Andy Yan @ 2025-04-24 0:42 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Arnd Bergmann, Sandy Huang, Heiko Stübner, Andy Yan,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Dmitry Baryshkov, Douglas Anderson, Damon Ding,
Arnd Bergmann, Heiko Stuebner, Geert Uytterhoeven,
Cristian Ciocaltea, dri-devel, linux-arm-kernel, linux-rockchip,
linux-kernel
Hi,
At 2025-04-24 01:18:45, "Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com> wrote:
>On Wed, Apr 23, 2025 at 06:44:16PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> DRM_DISPLAY_DP_AUX_BUS cannot be selected when CONFIG_OF is disabled:
>>
>> WARNING: unmet direct dependencies detected for DRM_DISPLAY_DP_AUX_BUS
>> Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n]
>> Selected by [y]:
>> - DRM_ROCKCHIP [=y] && HAS_IOMEM [=y] && DRM [=y] && ROCKCHIP_IOMMU [=y] && ROCKCHIP_ANALOGIX_DP [=y]
>>
>> Rockchip platforms all depend on OF anyway, so add the dependency here
>> for compile testing.
>>
>> Fixes: d7b4936b2bc0 ("drm/rockchip: analogix_dp: Add support to get panel from the DP AUX bus")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Andy Yan <andy.yan@rock-chips.com>
>> ---
>> drivers/gpu/drm/rockchip/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>
>Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>
>--
>With best wishes
>Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/rockchip: add CONFIG_OF dependency
2025-04-23 16:44 [PATCH] drm/rockchip: add CONFIG_OF dependency Arnd Bergmann
2025-04-23 17:18 ` Dmitry Baryshkov
@ 2025-05-01 11:03 ` Heiko Stuebner
1 sibling, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2025-05-01 11:03 UTC (permalink / raw)
To: Sandy Huang, Andy Yan, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Dmitry Baryshkov,
Douglas Anderson, Damon Ding, Arnd Bergmann
Cc: Heiko Stuebner, Arnd Bergmann, Heiko Stuebner, Geert Uytterhoeven,
Cristian Ciocaltea, dri-devel, linux-arm-kernel, linux-rockchip,
linux-kernel
On Wed, 23 Apr 2025 18:44:16 +0200, Arnd Bergmann wrote:
> DRM_DISPLAY_DP_AUX_BUS cannot be selected when CONFIG_OF is disabled:
>
> WARNING: unmet direct dependencies detected for DRM_DISPLAY_DP_AUX_BUS
> Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n]
> Selected by [y]:
> - DRM_ROCKCHIP [=y] && HAS_IOMEM [=y] && DRM [=y] && ROCKCHIP_IOMMU [=y] && ROCKCHIP_ANALOGIX_DP [=y]
>
> [...]
Applied, thanks!
[1/1] drm/rockchip: add CONFIG_OF dependency
commit: 4f1a965d592a0ca7d4ee2125f54d19ba8292295a
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-01 11:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-23 16:44 [PATCH] drm/rockchip: add CONFIG_OF dependency Arnd Bergmann
2025-04-23 17:18 ` Dmitry Baryshkov
2025-04-24 0:42 ` Andy Yan
2025-05-01 11:03 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox