public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Jernej Škrabec" <jernej.skrabec@gmail.com>,
	"Yixun Lan" <dlan@gentoo.org>, "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Samuel Holland" <samuel@sholland.org>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, clabbe.montjoie@gmail.com
Subject: Re: [PATCH 4/5] arm64: dts: allwinner: a527: add EMAC0 to Radxa A5E board
Date: Fri, 25 Apr 2025 14:22:50 +0100	[thread overview]
Message-ID: <20250425142250.006a029d@donnerap.manchester.arm.com> (raw)
In-Reply-To: <3681181a-0fbb-4979-9a7e-b8fe5c1b7c3c@lunn.ch>

On Fri, 25 Apr 2025 04:01:30 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> > Ah, right, I dimly remembered there was some hardware setting, but your
> > mentioning of those strap resistors now tickled my memory!
> > 
> > So according to the Radxa board schematic, RGMII0-RXD0/RXDLY is pulled
> > up to VCCIO via 4.7K, while RGMII0-RXD1/TXDLY is pulled to GND (also via
> > 4K7). According to the Motorcom YT8531 datasheet this means that RX
> > delay is enabled, but TX delay is not.
> > The Avaota board uses the same setup, albeit with an RTL8211F-CG PHY,
> > but its datasheet confirms it uses the same logic.
> > 
> > So does this mean we should say rgmii-rxid, so that the MAC adds the TX
> > delay? Does the stmmac driver actually support this? I couldn't find
> > this part by quickly checking the code.  
> 
> No. It is what the PCB provides which matters. A very small number of
> PCB have extra long clock lines to add the 2ns delay. Those boards
> should use 'rgmii'. All other boards should use rgmii-id, meaning the
> delays need to be provided somewhere else. Typically it is the PHY
> which adds the delays.
> 
> The strapping should not matter, the PHY driver will override that. So
> 'rgmii-id' should result in the PHY doing the basis 2ns in both
> directions. The MAC DT properties then add additional delays, which i
> consider fine tuning. Most systems don't actually need fine tuning,
> but the YT8531 is funky, it often does need it for some reason.

Ah, many thanks for the explanation, that clears that up! I read something
about the MAC adding delays, which confused me, but what you say now makes
sense.

Thanks!
Andre.

  reply	other threads:[~2025-04-25 13:22 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23 14:03 [PATCH 0/5] allwinner: Add EMAC0 support to A523 variant SoC Yixun Lan
2025-04-23 14:03 ` [PATCH 1/5] dt-bindings: sram: sunxi-sram: Add A523 compatible Yixun Lan
2025-04-24  0:46   ` Andre Przywara
2025-04-23 14:03 ` [PATCH 2/5] dt-bindings: arm: sunxi: Add A523 EMAC0 compatible Yixun Lan
2025-04-24  0:48   ` Andre Przywara
2025-04-23 14:03 ` [PATCH 3/5] arm64: dts: allwinner: a523: Add EMAC0 ethernet MAC Yixun Lan
2025-04-24  0:43   ` Andre Przywara
2025-04-24  3:28     ` Yixun Lan
2025-04-24 10:28       ` Chen-Yu Tsai
2025-04-23 14:03 ` [PATCH 4/5] arm64: dts: allwinner: a527: add EMAC0 to Radxa A5E board Yixun Lan
2025-04-23 16:58   ` Andrew Lunn
2025-04-24  0:42     ` Andre Przywara
2025-04-24 10:05       ` Yixun Lan
2025-04-24 12:05         ` Andre Przywara
2025-04-24 12:19         ` Andrew Lunn
2025-04-24 13:20           ` Andre Przywara
2025-04-24 13:32             ` Andrew Lunn
2025-04-24 12:16       ` Andrew Lunn
2025-04-24 12:41         ` Andre Przywara
2025-04-24 12:57           ` Andrew Lunn
2025-04-24 14:00             ` Andre Przywara
2025-04-24 18:38               ` Jernej Škrabec
2025-04-24 19:02                 ` Andrew Lunn
2025-04-24 19:05                   ` Chen-Yu Tsai
2025-04-24 19:21                     ` Jernej Škrabec
2025-04-24 22:56                 ` Andre Przywara
2025-04-25  2:01                   ` Andrew Lunn
2025-04-25 13:22                     ` Andre Przywara [this message]
2025-04-24  0:43   ` Andre Przywara
2025-04-24  3:24     ` Yixun Lan
2025-04-25  3:30   ` Chukun Pan
2025-04-25  7:46     ` Yixun Lan
2025-04-25 10:00       ` Chukun Pan
2025-04-23 14:03 ` [PATCH 5/5] arm64: dts: allwinner: t527: add EMAC0 to Avaoto-A1 board Yixun Lan
2025-04-23 16:59   ` Andrew Lunn
2025-04-24  1:17   ` Andre Przywara
2025-04-24  3:25     ` Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250425142250.006a029d@donnerap.manchester.arm.com \
    --to=andre.przywara@arm.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=clabbe.montjoie@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=edumazet@google.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox