public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: Andre Przywara <andre.przywara@arm.com>,
	Yixun Lan <dlan@gentoo.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Samuel Holland <samuel@sholland.org>,
	Maxime Ripard <mripard@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, clabbe.montjoie@gmail.com
Subject: Re: [PATCH 4/5] arm64: dts: allwinner: a527: add EMAC0 to Radxa A5E board
Date: Thu, 24 Apr 2025 21:02:35 +0200	[thread overview]
Message-ID: <7fcedce7-5cfe-48a4-9769-e6e7e82dc786@lunn.ch> (raw)
In-Reply-To: <4643958.LvFx2qVVIh@jernej-laptop>

> In my experience, vendor DT has proper delays specified, just 7 instead of
> 700, for example. What they get wrong, or better said, don't care, is phy
> mode. It's always set to rgmii because phy driver most of the time ignores
> this value and phy IC just uses mode set using resistors. Proper way here
> would be to check schematic and set phy mode according to that. This method
> always works, except for one board, which had resistors set wrong and
> phy mode configured over phy driver was actually fix for it.

What PHY driver is this? If it is ignoring the mode, it is broken.

We have had problems in the past in this respect. A PHY driver which
ignored the RGMII modes, and strapping was used. That 'worked' until
somebody built a board with broken strapping and added code to respect
the RGMII mode, overriding the strapping. It made that board work, but
broke lots of others which had the wrong RGMII mode....

If we have this again, i would like to know so we can try to get in
front of the problem, before we have lots of broken boards...

	Andrew

  reply	other threads:[~2025-04-24 19:03 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23 14:03 [PATCH 0/5] allwinner: Add EMAC0 support to A523 variant SoC Yixun Lan
2025-04-23 14:03 ` [PATCH 1/5] dt-bindings: sram: sunxi-sram: Add A523 compatible Yixun Lan
2025-04-24  0:46   ` Andre Przywara
2025-04-23 14:03 ` [PATCH 2/5] dt-bindings: arm: sunxi: Add A523 EMAC0 compatible Yixun Lan
2025-04-24  0:48   ` Andre Przywara
2025-04-23 14:03 ` [PATCH 3/5] arm64: dts: allwinner: a523: Add EMAC0 ethernet MAC Yixun Lan
2025-04-24  0:43   ` Andre Przywara
2025-04-24  3:28     ` Yixun Lan
2025-04-24 10:28       ` Chen-Yu Tsai
2025-04-23 14:03 ` [PATCH 4/5] arm64: dts: allwinner: a527: add EMAC0 to Radxa A5E board Yixun Lan
2025-04-23 16:58   ` Andrew Lunn
2025-04-24  0:42     ` Andre Przywara
2025-04-24 10:05       ` Yixun Lan
2025-04-24 12:05         ` Andre Przywara
2025-04-24 12:19         ` Andrew Lunn
2025-04-24 13:20           ` Andre Przywara
2025-04-24 13:32             ` Andrew Lunn
2025-04-24 12:16       ` Andrew Lunn
2025-04-24 12:41         ` Andre Przywara
2025-04-24 12:57           ` Andrew Lunn
2025-04-24 14:00             ` Andre Przywara
2025-04-24 18:38               ` Jernej Škrabec
2025-04-24 19:02                 ` Andrew Lunn [this message]
2025-04-24 19:05                   ` Chen-Yu Tsai
2025-04-24 19:21                     ` Jernej Škrabec
2025-04-24 22:56                 ` Andre Przywara
2025-04-25  2:01                   ` Andrew Lunn
2025-04-25 13:22                     ` Andre Przywara
2025-04-24  0:43   ` Andre Przywara
2025-04-24  3:24     ` Yixun Lan
2025-04-25  3:30   ` Chukun Pan
2025-04-25  7:46     ` Yixun Lan
2025-04-25 10:00       ` Chukun Pan
2025-04-23 14:03 ` [PATCH 5/5] arm64: dts: allwinner: t527: add EMAC0 to Avaoto-A1 board Yixun Lan
2025-04-23 16:59   ` Andrew Lunn
2025-04-24  1:17   ` Andre Przywara
2025-04-24  3:25     ` Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fcedce7-5cfe-48a4-9769-e6e7e82dc786@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andre.przywara@arm.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=clabbe.montjoie@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=edumazet@google.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox