* [PATCH] pinctrl: at91: drop unneeded dependency on OF_GPIO
@ 2025-05-02 10:08 Bartosz Golaszewski
2025-05-08 20:37 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2025-05-02 10:08 UTC (permalink / raw)
To: Linus Walleij, Paul Gazzillo, Necip Fazil Yildiran
Cc: oe-kbuild-all, linux-gpio, linux-kernel, Bartosz Golaszewski,
kernel test robot
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
This driver does not use any symbols from gpiolib-of.c. There's no
reason for it to select OF_GPIO directly. This addresses a kismet issue
reported by the build bot.
Fixes: 8e86af65f39d ("pinctrl: at91: allow building the module with COMPILE_TEST=y")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505010447.kUlI61vt-lkp@intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/pinctrl/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index db84d80b7e7d3..33db9104df178 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -107,7 +107,6 @@ config PINCTRL_AT91
select PINMUX
select PINCONF
select GPIOLIB
- select OF_GPIO
select GPIOLIB_IRQCHIP
help
Say Y here to enable the at91 pinctrl driver
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: at91: drop unneeded dependency on OF_GPIO
2025-05-02 10:08 [PATCH] pinctrl: at91: drop unneeded dependency on OF_GPIO Bartosz Golaszewski
@ 2025-05-08 20:37 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2025-05-08 20:37 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Paul Gazzillo, Necip Fazil Yildiran, oe-kbuild-all, linux-gpio,
linux-kernel, Bartosz Golaszewski, kernel test robot
On Fri, May 2, 2025 at 12:09 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> This driver does not use any symbols from gpiolib-of.c. There's no
> reason for it to select OF_GPIO directly. This addresses a kismet issue
> reported by the build bot.
>
> Fixes: 8e86af65f39d ("pinctrl: at91: allow building the module with COMPILE_TEST=y")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505010447.kUlI61vt-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Patch applied and pushed out, sorry for the delay!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-08 20:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-02 10:08 [PATCH] pinctrl: at91: drop unneeded dependency on OF_GPIO Bartosz Golaszewski
2025-05-08 20:37 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox