From: Max Kellermann <max.kellermann@ionos.com>
To: tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com,
cgroups@vger.kernel.org.com, linux-kernel@vger.kernel.org
Cc: Max Kellermann <max.kellermann@ionos.com>
Subject: [PATCH] kernel/cgroup/pids: add "pids.forks" counter
Date: Fri, 2 May 2025 14:19:30 +0200 [thread overview]
Message-ID: <20250502121930.4008251-1-max.kellermann@ionos.com> (raw)
Counts the number of fork()/clone() calls, similar to the "processes"
row in /proc/stat, but per cgroup. This helps with analyzing who was
responsible for peaks in the global "processes" counter.
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
---
Documentation/admin-guide/cgroup-v2.rst | 5 +++++
kernel/cgroup/pids.c | 18 ++++++++++++++++++
2 files changed, 23 insertions(+)
diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index 1a16ce68a4d7..88f996e083e2 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -2294,6 +2294,11 @@ PID Interface Files
The maximum value that the number of processes in the cgroup and its
descendants has ever reached.
+ pids.forks
+ A read-only single value file which exists on non-root cgroups.
+
+ The number of fork()/clone() calls (whether successful or not).
+
pids.events
A read-only flat-keyed file which exists on non-root cgroups. Unless
specified otherwise, a value change in this file generates a file
diff --git a/kernel/cgroup/pids.c b/kernel/cgroup/pids.c
index 8f61114c36dd..fb18741f85ba 100644
--- a/kernel/cgroup/pids.c
+++ b/kernel/cgroup/pids.c
@@ -49,6 +49,9 @@ enum pidcg_event {
struct pids_cgroup {
struct cgroup_subsys_state css;
+ /* the "pids.forks" counter */
+ atomic64_t forks;
+
/*
* Use 64-bit types so that we can safely represent "max" as
* %PIDS_MAX = (%PID_MAX_LIMIT + 1).
@@ -147,6 +150,7 @@ static void pids_charge(struct pids_cgroup *pids, int num)
struct pids_cgroup *p;
for (p = pids; parent_pids(p); p = parent_pids(p)) {
+ atomic64_add(num, &p->forks);
int64_t new = atomic64_add_return(num, &p->counter);
pids_update_watermark(p, new);
@@ -168,6 +172,7 @@ static int pids_try_charge(struct pids_cgroup *pids, int num, struct pids_cgroup
struct pids_cgroup *p, *q;
for (p = pids; parent_pids(p); p = parent_pids(p)) {
+ atomic64_add(num, &p->forks);
int64_t new = atomic64_add_return(num, &p->counter);
int64_t limit = atomic64_read(&p->limit);
@@ -342,6 +347,14 @@ static int pids_max_show(struct seq_file *sf, void *v)
return 0;
}
+static s64 pids_forks_read(struct cgroup_subsys_state *css,
+ struct cftype *cft)
+{
+ struct pids_cgroup *pids = css_pids(css);
+
+ return atomic64_read(&pids->forks);
+}
+
static s64 pids_current_read(struct cgroup_subsys_state *css,
struct cftype *cft)
{
@@ -404,6 +417,11 @@ static struct cftype pids_files[] = {
.flags = CFTYPE_NOT_ON_ROOT,
.read_s64 = pids_peak_read,
},
+ {
+ .name = "forks",
+ .read_s64 = pids_forks_read,
+ .flags = CFTYPE_NOT_ON_ROOT,
+ },
{
.name = "events",
.seq_show = pids_events_show,
--
2.47.2
next reply other threads:[~2025-05-02 12:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 12:19 Max Kellermann [this message]
2025-05-02 12:55 ` [PATCH] kernel/cgroup/pids: add "pids.forks" counter Michal Koutný
2025-05-02 13:23 ` Max Kellermann
2025-05-02 13:56 ` Michal Koutný
2025-05-02 18:37 ` Tejun Heo
2025-05-05 12:49 ` Max Kellermann
2025-05-05 16:31 ` Tejun Heo
2025-05-05 19:52 ` Max Kellermann
2025-05-05 21:15 ` Tejun Heo
2025-05-06 15:30 ` [PATCH PoC] kernel/cgroup/pids: refactor "pids.forks" into "pids.stat" Max Kellermann
2025-05-12 10:20 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250502121930.4008251-1-max.kellermann@ionos.com \
--to=max.kellermann@ionos.com \
--cc=cgroups@vger.kernel.org.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox