From: Tejun Heo <tj@kernel.org>
To: Max Kellermann <max.kellermann@ionos.com>
Cc: "Michal Koutný" <mkoutny@suse.com>,
hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH] kernel/cgroup/pids: add "pids.forks" counter
Date: Mon, 5 May 2025 11:15:36 -1000 [thread overview]
Message-ID: <aBkqeM0DoXUHHdgq@slm.duckdns.org> (raw)
In-Reply-To: <CAKPOu+-DoznsDeAn+AvyPkKyUW33ouLCv18QAO_0_42yXSk-3w@mail.gmail.com>
On Mon, May 05, 2025 at 09:52:59PM +0200, Max Kellermann wrote:
> On Mon, May 5, 2025 at 6:31 PM Tejun Heo <tj@kernel.org> wrote:
> > Oh, it's not specific to the cpu controller. The cpu part is just special.
> > Please see e.g. how blkcg or memcg uses rstat.
>
> Ah right. I have started implementing it that way, but it turns my
> simple 20 line patch into a 300 line monster. I still doubt this is
Hmm... let's see what the patch is like but I don't see why it'd be
monstrously complicated.
> worth the complexity, but if that's what you'll merge, fine!
Your 20 lines don't implement hierarhical behavior and will likely show up
in profiles at least in benchmarks on large multi socket machines
(especially if you try to make it hierarchical in a "simple" way).
Thanks.
--
tejun
next prev parent reply other threads:[~2025-05-05 21:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-02 12:19 [PATCH] kernel/cgroup/pids: add "pids.forks" counter Max Kellermann
2025-05-02 12:55 ` Michal Koutný
2025-05-02 13:23 ` Max Kellermann
2025-05-02 13:56 ` Michal Koutný
2025-05-02 18:37 ` Tejun Heo
2025-05-05 12:49 ` Max Kellermann
2025-05-05 16:31 ` Tejun Heo
2025-05-05 19:52 ` Max Kellermann
2025-05-05 21:15 ` Tejun Heo [this message]
2025-05-06 15:30 ` [PATCH PoC] kernel/cgroup/pids: refactor "pids.forks" into "pids.stat" Max Kellermann
2025-05-12 10:20 ` Michal Koutný
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBkqeM0DoXUHHdgq@slm.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
--cc=mkoutny@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox