[PATCH v2 0/6] cdx: Minor cleanups

[PATCH v2 0/6] cdx: Minor cleanups

[Krzysztof Kozlowski]

Changes in v2:
- Patch #1: Add HAS_DMA dependency
- Patch #5: New patch, split from previous
- Link to v1: https://lore.kernel.org/r/20250425-cdx-clean-v1-0-ea2002dd400d@linaro.org

Few simple cleanups for CDX drivers.

Best regards,
Krzysztof

---
Krzysztof Kozlowski (6):
      cdx: Enable compile testing
      cdx: controller: Simplify with dev_err_probe()
      cdx: controller: Drop useless probe success message
      cdx: controller: Do not open-code module_platform_driver()
      cdx: controller: Drop unneeded driver.pm NULL assignment
      cdx: MAINTAINERS: Explicitly mention Greg who handles patches

 MAINTAINERS                             |  1 +
 drivers/cdx/Kconfig                     |  2 +-
 drivers/cdx/controller/Kconfig          |  1 +
 drivers/cdx/controller/cdx_controller.c | 27 +++------------------------
 4 files changed, 6 insertions(+), 25 deletions(-)
---
base-commit: 393d0c54cae31317deaa9043320c5fd9454deabc
change-id: 20250425-cdx-clean-af4a9f1c0c53

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

[PATCH v2 1/6] cdx: Enable compile testing

[Krzysztof Kozlowski]

There is no code limited to ARM64 or OF/Devicetree in the CDX bus
driver, so CDX_BUS can be compile tested on all platforms.
CDX_CONTROLLER on the other hand selects REMOTEPROC which depends on
HAS_DMA, so add that dependency for compile testing.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/cdx/Kconfig            | 2 +-
 drivers/cdx/controller/Kconfig | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/cdx/Kconfig b/drivers/cdx/Kconfig
index a08958485e316a1a3e00390d90c7a9eaa518d0e8..1f1e360507d7d5c33671c601534e82f2d4de0424 100644
--- a/drivers/cdx/Kconfig
+++ b/drivers/cdx/Kconfig
@@ -7,7 +7,7 @@
 
 config CDX_BUS
 	bool "CDX Bus driver"
-	depends on OF && ARM64
+	depends on OF && ARM64 || COMPILE_TEST
 	help
 	  Driver to enable Composable DMA Transfer(CDX) Bus. CDX bus
 	  exposes Fabric devices which uses composable DMA IP to the
diff --git a/drivers/cdx/controller/Kconfig b/drivers/cdx/controller/Kconfig
index f8e729761aeed03302d6c625b74f5e54bfd1bcbf..0641a4c21e660833efd9ac05e9431b58aa10ec03 100644
--- a/drivers/cdx/controller/Kconfig
+++ b/drivers/cdx/controller/Kconfig
@@ -9,6 +9,7 @@ if CDX_BUS
 
 config CDX_CONTROLLER
 	tristate "CDX bus controller"
+	depends on HAS_DMA
 	select GENERIC_MSI_IRQ
 	select REMOTEPROC
 	select RPMSG

-- 
2.45.2

[PATCH v2 2/6] cdx: controller: Simplify with dev_err_probe()

[Krzysztof Kozlowski]

Simplify printing probe failures and handling deferred probe with
dev_err_probe().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/cdx/controller/cdx_controller.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/cdx/controller/cdx_controller.c b/drivers/cdx/controller/cdx_controller.c
index d623f9c7517a86c06082c0db348688e7f33b7be6..3df35833f0e0a994af0606eee0dc1dfc9c7c22f9 100644
--- a/drivers/cdx/controller/cdx_controller.c
+++ b/drivers/cdx/controller/cdx_controller.c
@@ -195,15 +195,13 @@ static int xlnx_cdx_probe(struct platform_device *pdev)
 	/* Create MSI domain */
 	cdx->msi_domain = cdx_msi_domain_init(&pdev->dev);
 	if (!cdx->msi_domain) {
-		dev_err(&pdev->dev, "cdx_msi_domain_init() failed");
-		ret = -ENODEV;
+		ret = dev_err_probe(&pdev->dev, -ENODEV, "cdx_msi_domain_init() failed");
 		goto cdx_msi_fail;
 	}
 
 	ret = cdx_setup_rpmsg(pdev);
 	if (ret) {
-		if (ret != -EPROBE_DEFER)
-			dev_err(&pdev->dev, "Failed to register CDX RPMsg transport\n");
+		dev_err_probe(&pdev->dev, ret, "Failed to register CDX RPMsg transport\n");
 		goto cdx_rpmsg_fail;
 	}
 

-- 
2.45.2

[PATCH v2 3/6] cdx: controller: Drop useless probe success message

[Krzysztof Kozlowski]

Drivers should be silent on probe success, unless they print some useful
information.  Printing "hey I probed" is not useful and kernel already
gives mechanism to investigate that (e.g. sysfs, tracing, initcall
debug).

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/cdx/controller/cdx_controller.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/cdx/controller/cdx_controller.c b/drivers/cdx/controller/cdx_controller.c
index 3df35833f0e0a994af0606eee0dc1dfc9c7c22f9..fce90926d3378ae60166426cbf8e4a4fe014af86 100644
--- a/drivers/cdx/controller/cdx_controller.c
+++ b/drivers/cdx/controller/cdx_controller.c
@@ -205,7 +205,6 @@ static int xlnx_cdx_probe(struct platform_device *pdev)
 		goto cdx_rpmsg_fail;
 	}
 
-	dev_info(&pdev->dev, "Successfully registered CDX controller with RPMsg as transport\n");
 	return 0;
 
 cdx_rpmsg_fail:

-- 
2.45.2

[PATCH v2 4/6] cdx: controller: Do not open-code module_platform_driver()

[Krzysztof Kozlowski]

Replace standard platform_driver_register() boilerplate with
module_platform_driver() to make code smaller.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/cdx/controller/cdx_controller.c | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

diff --git a/drivers/cdx/controller/cdx_controller.c b/drivers/cdx/controller/cdx_controller.c
index fce90926d3378ae60166426cbf8e4a4fe014af86..bfb5ac2d861f2708214ae28922a7c0cfdcdf5cc6 100644
--- a/drivers/cdx/controller/cdx_controller.c
+++ b/drivers/cdx/controller/cdx_controller.c
@@ -250,24 +250,7 @@ static struct platform_driver cdx_pdriver = {
 	.remove = xlnx_cdx_remove,
 };
 
-static int __init cdx_controller_init(void)
-{
-	int ret;
-
-	ret = platform_driver_register(&cdx_pdriver);
-	if (ret)
-		pr_err("platform_driver_register() failed: %d\n", ret);
-
-	return ret;
-}
-
-static void __exit cdx_controller_exit(void)
-{
-	platform_driver_unregister(&cdx_pdriver);
-}
-
-module_init(cdx_controller_init);
-module_exit(cdx_controller_exit);
+module_platform_driver(cdx_pdriver);
 
 MODULE_AUTHOR("AMD Inc.");
 MODULE_DESCRIPTION("CDX controller for AMD devices");

-- 
2.45.2

[PATCH v2 5/6] cdx: controller: Drop unneeded driver.pm NULL assignment

[Krzysztof Kozlowski]

Struct driver in platform_driver is zero-ed so there is no need to
assign its 'pm' member to NULL.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/cdx/controller/cdx_controller.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/cdx/controller/cdx_controller.c b/drivers/cdx/controller/cdx_controller.c
index bfb5ac2d861f2708214ae28922a7c0cfdcdf5cc6..fca83141e3e66e68e6916077833db2b7d816395f 100644
--- a/drivers/cdx/controller/cdx_controller.c
+++ b/drivers/cdx/controller/cdx_controller.c
@@ -243,7 +243,6 @@ MODULE_DEVICE_TABLE(of, cdx_match_table);
 static struct platform_driver cdx_pdriver = {
 	.driver = {
 		   .name = "cdx-controller",
-		   .pm = NULL,
 		   .of_match_table = cdx_match_table,
 		   },
 	.probe = xlnx_cdx_probe,

-- 
2.45.2

[PATCH v2 6/6] cdx: MAINTAINERS: Explicitly mention Greg who handles patches

[Krzysztof Kozlowski]

Patches for CDX bus drivers are applied by Greg Kroah-Hartman, so list
him in the maintainers entry because otherwise contributors would be
surprised their patches got lost.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index b2c3be5f6131432647dd01f22bbf4bf1c8bde9e6..505d7d45ad7d1c007e89a555264ff8cbeaf6e1f4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1008,6 +1008,7 @@ F:	Documentation/devicetree/bindings/w1/amd,axi-1wire-host.yaml
 F:	drivers/w1/masters/amd_axi_w1.c
 
 AMD CDX BUS DRIVER
+M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 M:	Nipun Gupta <nipun.gupta@amd.com>
 M:	Nikhil Agarwal <nikhil.agarwal@amd.com>
 S:	Maintained

-- 
2.45.2

Re: [PATCH v2 6/6] cdx: MAINTAINERS: Explicitly mention Greg who handles patches

[Greg Kroah-Hartman]

On Wed, Apr 30, 2025 at 08:41:34PM +0200, Krzysztof Kozlowski wrote:
> Patches for CDX bus drivers are applied by Greg Kroah-Hartman, so list
> him in the maintainers entry because otherwise contributors would be
> surprised their patches got lost.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b2c3be5f6131432647dd01f22bbf4bf1c8bde9e6..505d7d45ad7d1c007e89a555264ff8cbeaf6e1f4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1008,6 +1008,7 @@ F:	Documentation/devicetree/bindings/w1/amd,axi-1wire-host.yaml
>  F:	drivers/w1/masters/amd_axi_w1.c
>  
>  AMD CDX BUS DRIVER
> +M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Sorry, but no, I'm not the maintainer of this driver.  It's up to the
maintainer(s) of it to send me the patches on to be merged, it is not up
to me to maintain the code at all.

thanks,

greg k-h

Re: [PATCH v2 6/6] cdx: MAINTAINERS: Explicitly mention Greg who handles patches

[Krzysztof Kozlowski]

On 01/05/2025 17:59, Greg Kroah-Hartman wrote:
> On Wed, Apr 30, 2025 at 08:41:34PM +0200, Krzysztof Kozlowski wrote:
>> Patches for CDX bus drivers are applied by Greg Kroah-Hartman, so list
>> him in the maintainers entry because otherwise contributors would be
>> surprised their patches got lost.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index b2c3be5f6131432647dd01f22bbf4bf1c8bde9e6..505d7d45ad7d1c007e89a555264ff8cbeaf6e1f4 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1008,6 +1008,7 @@ F:	Documentation/devicetree/bindings/w1/amd,axi-1wire-host.yaml
>>  F:	drivers/w1/masters/amd_axi_w1.c
>>  
>>  AMD CDX BUS DRIVER
>> +M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Sorry, but no, I'm not the maintainer of this driver.  It's up to the
> maintainer(s) of it to send me the patches on to be merged, it is not up
> to me to maintain the code at all.
> 
Sure, I understand. I  will send a v3 without maintainers patch and I
assume the maintainers will pick them up (unless drivers are orphaned).

Best regards,
Krzysztof

Re: [PATCH v2 6/6] cdx: MAINTAINERS: Explicitly mention Greg who handles patches

[Krzysztof Kozlowski]

On 01/05/2025 18:06, Krzysztof Kozlowski wrote:
> On 01/05/2025 17:59, Greg Kroah-Hartman wrote:
>> On Wed, Apr 30, 2025 at 08:41:34PM +0200, Krzysztof Kozlowski wrote:
>>> Patches for CDX bus drivers are applied by Greg Kroah-Hartman, so list
>>> him in the maintainers entry because otherwise contributors would be
>>> surprised their patches got lost.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>>  MAINTAINERS | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index b2c3be5f6131432647dd01f22bbf4bf1c8bde9e6..505d7d45ad7d1c007e89a555264ff8cbeaf6e1f4 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1008,6 +1008,7 @@ F:	Documentation/devicetree/bindings/w1/amd,axi-1wire-host.yaml
>>>  F:	drivers/w1/masters/amd_axi_w1.c
>>>  
>>>  AMD CDX BUS DRIVER
>>> +M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>
>> Sorry, but no, I'm not the maintainer of this driver.  It's up to the
>> maintainer(s) of it to send me the patches on to be merged, it is not up
>> to me to maintain the code at all.
>>
> Sure, I understand. I  will send a v3 without maintainers patch and I
> assume the maintainers will pick them up (unless drivers are orphaned).


And now I found this:
https://lore.kernel.org/lkml/929198a2-6b3b-0f1b-3f36-cd8955ca6f19@amd.com/

"We do not maintain a tree and  patches go via Greg's tree."

which means that patches won't be picked up. Your email does not pop up
on b4/get_maintainers. Overall this means cdx driver might be abandoned,
from contributors point of view.

If that's the case I will send a patch making this orphaned.

More patches which never received any attention or were not picked up:

https://lore.kernel.org/lkml/20250118070833.27201-1-chenqiuji666@gmail.com/
https://lore.kernel.org/lkml/20241203084409.2747897-1-abhijit.gangurde@amd.com/
https://lore.kernel.org/lkml/20250425133929.646493-2-robin.murphy@arm.com/


Best regards,
Krzysztof

Re: [PATCH v2 6/6] cdx: MAINTAINERS: Explicitly mention Greg who handles patches

[Gupta, Nipun]

On 02-05-2025 11:57, Krzysztof Kozlowski wrote:
> On 01/05/2025 18:06, Krzysztof Kozlowski wrote:
>> On 01/05/2025 17:59, Greg Kroah-Hartman wrote:
>>> On Wed, Apr 30, 2025 at 08:41:34PM +0200, Krzysztof Kozlowski wrote:
>>>> Patches for CDX bus drivers are applied by Greg Kroah-Hartman, so list
>>>> him in the maintainers entry because otherwise contributors would be
>>>> surprised their patches got lost.
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> ---
>>>>   MAINTAINERS | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index b2c3be5f6131432647dd01f22bbf4bf1c8bde9e6..505d7d45ad7d1c007e89a555264ff8cbeaf6e1f4 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -1008,6 +1008,7 @@ F:	Documentation/devicetree/bindings/w1/amd,axi-1wire-host.yaml
>>>>   F:	drivers/w1/masters/amd_axi_w1.c
>>>>   
>>>>   AMD CDX BUS DRIVER
>>>> +M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>
>>> Sorry, but no, I'm not the maintainer of this driver.  It's up to the
>>> maintainer(s) of it to send me the patches on to be merged, it is not up
>>> to me to maintain the code at all.
>>>
>> Sure, I understand. I  will send a v3 without maintainers patch and I
>> assume the maintainers will pick them up (unless drivers are orphaned).
> 
> 
> And now I found this:
> https://lore.kernel.org/lkml/929198a2-6b3b-0f1b-3f36-cd8955ca6f19@amd.com/
> 
> "We do not maintain a tree and  patches go via Greg's tree."
> 
> which means that patches won't be picked up. Your email does not pop up
> on b4/get_maintainers. Overall this means cdx driver might be abandoned,
> from contributors point of view.

We usually copy Greg once the patches are reviewed/acked from our side 
if he is not already on the list. Do you suggest any alternate approach 
in maintaining the drivers like cdx which do not have their own tree?

> 
> If that's the case I will send a patch making this orphaned.
> 
> More patches which never received any attention or were not picked up:
> 
> https://lore.kernel.org/lkml/20250118070833.27201-1-chenqiuji666@gmail.com/

This is applied on the Linux tree.

> https://lore.kernel.org/lkml/20241203084409.2747897-1-abhijit.gangurde@amd.com/

This is also applied on the Linux tree.

> https://lore.kernel.org/lkml/20250425133929.646493-2-robin.murphy@arm.com/

This was recently sent and we will review in the upcoming week.

> 
> 
> Best regards,
> Krzysztof

Re: [PATCH v2 6/6] cdx: MAINTAINERS: Explicitly mention Greg who handles patches

[Krzysztof Kozlowski]

On 02/05/2025 08:52, Gupta, Nipun wrote:
> 
> 
> On 02-05-2025 11:57, Krzysztof Kozlowski wrote:
>> On 01/05/2025 18:06, Krzysztof Kozlowski wrote:
>>> On 01/05/2025 17:59, Greg Kroah-Hartman wrote:
>>>> On Wed, Apr 30, 2025 at 08:41:34PM +0200, Krzysztof Kozlowski wrote:
>>>>> Patches for CDX bus drivers are applied by Greg Kroah-Hartman, so list
>>>>> him in the maintainers entry because otherwise contributors would be
>>>>> surprised their patches got lost.
>>>>>
>>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>> ---
>>>>>   MAINTAINERS | 1 +
>>>>>   1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>> index b2c3be5f6131432647dd01f22bbf4bf1c8bde9e6..505d7d45ad7d1c007e89a555264ff8cbeaf6e1f4 100644
>>>>> --- a/MAINTAINERS
>>>>> +++ b/MAINTAINERS
>>>>> @@ -1008,6 +1008,7 @@ F:	Documentation/devicetree/bindings/w1/amd,axi-1wire-host.yaml
>>>>>   F:	drivers/w1/masters/amd_axi_w1.c
>>>>>   
>>>>>   AMD CDX BUS DRIVER
>>>>> +M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>>
>>>> Sorry, but no, I'm not the maintainer of this driver.  It's up to the
>>>> maintainer(s) of it to send me the patches on to be merged, it is not up
>>>> to me to maintain the code at all.
>>>>
>>> Sure, I understand. I  will send a v3 without maintainers patch and I
>>> assume the maintainers will pick them up (unless drivers are orphaned).
>>
>>
>> And now I found this:
>> https://lore.kernel.org/lkml/929198a2-6b3b-0f1b-3f36-cd8955ca6f19@amd.com/
>>
>> "We do not maintain a tree and  patches go via Greg's tree."
>>
>> which means that patches won't be picked up. Your email does not pop up
>> on b4/get_maintainers. Overall this means cdx driver might be abandoned,
>> from contributors point of view.
> 
> We usually copy Greg once the patches are reviewed/acked from our side 
> if he is not already on the list. Do you suggest any alternate approach 
> in maintaining the drivers like cdx which do not have their own tree?


Either you have the tree or person having the tree appears on
maintainers output. There is no other option.

If you refuse to take the patches and handle them, I claim this is
orphaned from the kernel point of view, even if occasionally Greg takes
these. I believe Greg was already pointing this issue more than once.

> 
>>
>> If that's the case I will send a patch making this orphaned.
>>
>> More patches which never received any attention or were not picked up:
>>
>> https://lore.kernel.org/lkml/20250118070833.27201-1-chenqiuji666@gmail.com/
> 
> This is applied on the Linux tree.

Yeah, but no reviews were given.

> 
>> https://lore.kernel.org/lkml/20241203084409.2747897-1-abhijit.gangurde@amd.com/
> 
> This is also applied on the Linux tree.

Same here.

> 
>> https://lore.kernel.org/lkml/20250425133929.646493-2-robin.murphy@arm.com/
> 
> This was recently sent and we will review in the upcoming week.

It already has been one week, but I guess two weeks is still acceptable
for hobbyist. For company-related maintainership not really.


Best regards,
Krzysztof

Re: [PATCH v2 6/6] cdx: MAINTAINERS: Explicitly mention Greg who handles patches

[Greg Kroah-Hartman]

On Fri, May 02, 2025 at 08:57:12AM +0200, Krzysztof Kozlowski wrote:
> On 02/05/2025 08:52, Gupta, Nipun wrote:
> > 
> > 
> > On 02-05-2025 11:57, Krzysztof Kozlowski wrote:
> >> On 01/05/2025 18:06, Krzysztof Kozlowski wrote:
> >>> On 01/05/2025 17:59, Greg Kroah-Hartman wrote:
> >>>> On Wed, Apr 30, 2025 at 08:41:34PM +0200, Krzysztof Kozlowski wrote:
> >>>>> Patches for CDX bus drivers are applied by Greg Kroah-Hartman, so list
> >>>>> him in the maintainers entry because otherwise contributors would be
> >>>>> surprised their patches got lost.
> >>>>>
> >>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>>>> ---
> >>>>>   MAINTAINERS | 1 +
> >>>>>   1 file changed, 1 insertion(+)
> >>>>>
> >>>>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>>>> index b2c3be5f6131432647dd01f22bbf4bf1c8bde9e6..505d7d45ad7d1c007e89a555264ff8cbeaf6e1f4 100644
> >>>>> --- a/MAINTAINERS
> >>>>> +++ b/MAINTAINERS
> >>>>> @@ -1008,6 +1008,7 @@ F:	Documentation/devicetree/bindings/w1/amd,axi-1wire-host.yaml
> >>>>>   F:	drivers/w1/masters/amd_axi_w1.c
> >>>>>   
> >>>>>   AMD CDX BUS DRIVER
> >>>>> +M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >>>>
> >>>> Sorry, but no, I'm not the maintainer of this driver.  It's up to the
> >>>> maintainer(s) of it to send me the patches on to be merged, it is not up
> >>>> to me to maintain the code at all.
> >>>>
> >>> Sure, I understand. I  will send a v3 without maintainers patch and I
> >>> assume the maintainers will pick them up (unless drivers are orphaned).
> >>
> >>
> >> And now I found this:
> >> https://lore.kernel.org/lkml/929198a2-6b3b-0f1b-3f36-cd8955ca6f19@amd.com/
> >>
> >> "We do not maintain a tree and  patches go via Greg's tree."
> >>
> >> which means that patches won't be picked up. Your email does not pop up
> >> on b4/get_maintainers. Overall this means cdx driver might be abandoned,
> >> from contributors point of view.
> > 
> > We usually copy Greg once the patches are reviewed/acked from our side 
> > if he is not already on the list. Do you suggest any alternate approach 
> > in maintaining the drivers like cdx which do not have their own tree?
> 
> 
> Either you have the tree or person having the tree appears on
> maintainers output. There is no other option.

What?  No, we do this for many subsystems already.  Look at the entry
for "USB TYPEC BUS FOR ALTERNATE MODES" as one simple example.  The
patches go to the list, Heikki reviews them and if he says "ack" or
"signed-off-by" then I pick them up and add them to my tree and away the
patch goes.

That last bit is NOT explicitly documented in MAINTAINERS as it does not
need to be (otherwise you will have too many lines in that file).  This
is just one more subsystem that does it this way, not a big deal.

> If you refuse to take the patches and handle them, I claim this is
> orphaned from the kernel point of view, even if occasionally Greg takes
> these. I believe Greg was already pointing this issue more than once.

They are "handling" them in that they are reviewing them when they get
the chance and then I need to then pick them up.  Again, totally normal.

I will not dispute the fact that this is confusing for submitters, and
maybe the cdx maintainers need to get a tree and start doing more work,
but I am NOT going to be the one telling any maintainer to do more work
than they are willing to do as that would just be rude :)

thanks,

greg k-h

Re: [PATCH v2 6/6] cdx: MAINTAINERS: Explicitly mention Greg who handles patches

[Krzysztof Kozlowski]

On 02/05/2025 09:17, Greg Kroah-Hartman wrote:
> On Fri, May 02, 2025 at 08:57:12AM +0200, Krzysztof Kozlowski wrote:
>> On 02/05/2025 08:52, Gupta, Nipun wrote:
>>>
>>>
>>> On 02-05-2025 11:57, Krzysztof Kozlowski wrote:
>>>> On 01/05/2025 18:06, Krzysztof Kozlowski wrote:
>>>>> On 01/05/2025 17:59, Greg Kroah-Hartman wrote:
>>>>>> On Wed, Apr 30, 2025 at 08:41:34PM +0200, Krzysztof Kozlowski wrote:
>>>>>>> Patches for CDX bus drivers are applied by Greg Kroah-Hartman, so list
>>>>>>> him in the maintainers entry because otherwise contributors would be
>>>>>>> surprised their patches got lost.
>>>>>>>
>>>>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>>>> ---
>>>>>>>   MAINTAINERS | 1 +
>>>>>>>   1 file changed, 1 insertion(+)
>>>>>>>
>>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>>>> index b2c3be5f6131432647dd01f22bbf4bf1c8bde9e6..505d7d45ad7d1c007e89a555264ff8cbeaf6e1f4 100644
>>>>>>> --- a/MAINTAINERS
>>>>>>> +++ b/MAINTAINERS
>>>>>>> @@ -1008,6 +1008,7 @@ F:	Documentation/devicetree/bindings/w1/amd,axi-1wire-host.yaml
>>>>>>>   F:	drivers/w1/masters/amd_axi_w1.c
>>>>>>>   
>>>>>>>   AMD CDX BUS DRIVER
>>>>>>> +M:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>>>>
>>>>>> Sorry, but no, I'm not the maintainer of this driver.  It's up to the
>>>>>> maintainer(s) of it to send me the patches on to be merged, it is not up
>>>>>> to me to maintain the code at all.
>>>>>>
>>>>> Sure, I understand. I  will send a v3 without maintainers patch and I
>>>>> assume the maintainers will pick them up (unless drivers are orphaned).
>>>>
>>>>
>>>> And now I found this:
>>>> https://lore.kernel.org/lkml/929198a2-6b3b-0f1b-3f36-cd8955ca6f19@amd.com/
>>>>
>>>> "We do not maintain a tree and  patches go via Greg's tree."
>>>>
>>>> which means that patches won't be picked up. Your email does not pop up
>>>> on b4/get_maintainers. Overall this means cdx driver might be abandoned,
>>>> from contributors point of view.
>>>
>>> We usually copy Greg once the patches are reviewed/acked from our side 
>>> if he is not already on the list. Do you suggest any alternate approach 
>>> in maintaining the drivers like cdx which do not have their own tree?
>>
>>
>> Either you have the tree or person having the tree appears on
>> maintainers output. There is no other option.
> 
> What?  No, we do this for many subsystems already.  Look at the entry
> for "USB TYPEC BUS FOR ALTERNATE MODES" as one simple example.  The
> patches go to the list, Heikki reviews them and if he says "ack" or
> "signed-off-by" then I pick them up and add them to my tree and away the
> patch goes.

You are CC-ed on these Typec alternate modes, as the subsystem
maintainer or patches-picking-up-maintainer:

*  1 Heikki Krogerus <heikki.krogerus@linux.intel.com>
     maintainer:USB TYPEC BUS FOR ALTERNATE MODES
*  2 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
     maintainer:USB SUBSYSTEM

Here, you are not Cced at all. That's why this is different.

> 
> That last bit is NOT explicitly documented in MAINTAINERS as it does not
> need to be (otherwise you will have too many lines in that file).  This
> is just one more subsystem that does it this way, not a big deal.

It is basically the only one subsystem doing that way.

Basically this looks like incomplete subsystem or a driver without
subsystem. With the different that we have many per-driver entries but
they are part of some subsystem maintainer's scope.

> 
>> If you refuse to take the patches and handle them, I claim this is
>> orphaned from the kernel point of view, even if occasionally Greg takes
>> these. I believe Greg was already pointing this issue more than once.
> 
> They are "handling" them in that they are reviewing them when they get
> the chance and then I need to then pick them up.  Again, totally normal.

I agree they are handling them. I disagree this is totally normal that
get_maintainers.pl does not point out the actual subsystem/maintainer
handling the patches.

If I remember correctly, it was Linus who said he uses
`get_maintainer.pl -f FILE/PATH`, so with his workflow he would not get
the maintainer's address (yours). One would have to go through git
history to look for SoB, but that's not normal process.

That's an exception.


Best regards,
Krzysztof