[PATCH 0/2] nvmem: fixes for 6.15

[PATCH 0/2] nvmem: fixes for 6.15

[srini]

From: Srinivas Kandagatla <srini@kernel.org>

Hi Greg, 

Here are two fixes in nvmem for 6.15, Could you please queue
these for next possible rc.

fixes include
	- a fix in zynqmp_nvmem provider during cleanup.
	- fix a link failure due to newly added crc checking 


Thanks,
Srini

Arnd Bergmann (1):
  nvmem: rmem: select CONFIG_CRC32

Peter Korsgaard (1):
  nvmem: zynqmp_nvmem: unbreak driver after cleanup

 drivers/nvmem/Kconfig        | 1 +
 drivers/nvmem/zynqmp_nvmem.c | 1 +
 2 files changed, 2 insertions(+)

-- 
2.43.0

[PATCH 1/2] nvmem: rmem: select CONFIG_CRC32

[srini]

From: Arnd Bergmann <arnd@arndb.de>

The newly added crc checking leads to a link failure if CRC32
itself is disabled:

x86_64-linux-ld: vmlinux.o: in function `rmem_eyeq5_checksum':
rmem.c:(.text+0x52341b): undefined reference to `crc32_le_arch'

Fixes: 7e606c311f70 ("nvmem: rmem: add CRC validation for Mobileye EyeQ5 NVMEM")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Srinivas Kandagatla <srini@kernel.org>
---
 drivers/nvmem/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index 8671b7c974b9..eceb3cdb421f 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -260,6 +260,7 @@ config NVMEM_RCAR_EFUSE
 config NVMEM_RMEM
 	tristate "Reserved Memory Based Driver Support"
 	depends on HAS_IOMEM
+	select CRC32
 	help
 	  This driver maps reserved memory into an nvmem device. It might be
 	  useful to expose information left by firmware in memory.
-- 
2.43.0

Re: [PATCH 1/2] nvmem: rmem: select CONFIG_CRC32

[Greg KH]

On Fri, May 09, 2025 at 01:24:06PM +0100, srini@kernel.org wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly added crc checking leads to a link failure if CRC32
> itself is disabled:
> 
> x86_64-linux-ld: vmlinux.o: in function `rmem_eyeq5_checksum':
> rmem.c:(.text+0x52341b): undefined reference to `crc32_le_arch'
> 
> Fixes: 7e606c311f70 ("nvmem: rmem: add CRC validation for Mobileye EyeQ5 NVMEM")

You forgot to cc: stable :(

[PATCH 2/2] nvmem: zynqmp_nvmem: unbreak driver after cleanup

[srini]

From: Peter Korsgaard <peter@korsgaard.com>

Commit 29be47fcd6a0 ("nvmem: zynqmp_nvmem: zynqmp_nvmem_probe cleanup")
changed the driver to expect the device pointer to be passed as the
"context", but in nvmem the context parameter comes from nvmem_config.priv
which is never set - Leading to null pointer exceptions when the device is
accessed.

Fixes: 29be47fcd6a0 ("nvmem: zynqmp_nvmem: zynqmp_nvmem_probe cleanup")
Cc: stable@vger.kernel.org
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Reviewed-by: Michal Simek <michal.simek@amd.com>
Tested-by: Michal Simek <michal.simek@amd.com>
Signed-off-by: Srinivas Kandagatla <srini@kernel.org>
---
 drivers/nvmem/zynqmp_nvmem.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvmem/zynqmp_nvmem.c b/drivers/nvmem/zynqmp_nvmem.c
index 8682adaacd69..7da717d6c7fa 100644
--- a/drivers/nvmem/zynqmp_nvmem.c
+++ b/drivers/nvmem/zynqmp_nvmem.c
@@ -213,6 +213,7 @@ static int zynqmp_nvmem_probe(struct platform_device *pdev)
 	econfig.word_size = 1;
 	econfig.size = ZYNQMP_NVMEM_SIZE;
 	econfig.dev = dev;
+	econfig.priv = dev;
 	econfig.add_legacy_fixed_of_cells = true;
 	econfig.reg_read = zynqmp_nvmem_read;
 	econfig.reg_write = zynqmp_nvmem_write;
-- 
2.43.0