* [PATCH 1/1] cxl/feature: Remove redundant code of get supported features
@ 2025-05-16 14:32 Li Ming
2025-05-16 15:24 ` Dave Jiang
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Li Ming @ 2025-05-16 14:32 UTC (permalink / raw)
To: dave, jonathan.cameron, dave.jiang, alison.schofield,
vishal.l.verma, ira.weiny, dan.j.williams
Cc: linux-cxl, linux-kernel, Li Ming
In cxlctl_get_supported_features(), there is a code block that handles
the case where the requested is equal to 0. But the code following the
code block can also handle this situation. So the code block is not
needed.
Signed-off-by: Li Ming <ming.li@zohomail.com>
---
base-commit: 82f2b0b97b36ee3fcddf0f0780a9a0825d52fec3 v6.15-rc6
---
drivers/cxl/core/features.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c
index 1498e2369c37..2d3a6d36a761 100644
--- a/drivers/cxl/core/features.c
+++ b/drivers/cxl/core/features.c
@@ -416,14 +416,6 @@ static void *cxlctl_get_supported_features(struct cxl_features_state *cxlfs,
rpc_out->size = struct_size(feat_out, ents, requested);
feat_out = &rpc_out->get_sup_feats_out;
- if (requested == 0) {
- feat_out->num_entries = cpu_to_le16(requested);
- feat_out->supported_feats =
- cpu_to_le16(cxlfs->entries->num_features);
- rpc_out->retval = CXL_MBOX_CMD_RC_SUCCESS;
- *out_len = out_size;
- return no_free_ptr(rpc_out);
- }
for (i = start, pos = &feat_out->ents[0];
i < cxlfs->entries->num_features; i++, pos++) {
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] cxl/feature: Remove redundant code of get supported features
2025-05-16 14:32 [PATCH 1/1] cxl/feature: Remove redundant code of get supported features Li Ming
@ 2025-05-16 15:24 ` Dave Jiang
2025-05-19 15:33 ` Jonathan Cameron
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Dave Jiang @ 2025-05-16 15:24 UTC (permalink / raw)
To: Li Ming, dave, jonathan.cameron, alison.schofield, vishal.l.verma,
ira.weiny, dan.j.williams
Cc: linux-cxl, linux-kernel
On 5/16/25 7:32 AM, Li Ming wrote:
> In cxlctl_get_supported_features(), there is a code block that handles
> the case where the requested is equal to 0. But the code following the
> code block can also handle this situation. So the code block is not
> needed.
>
> Signed-off-by: Li Ming <ming.li@zohomail.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> base-commit: 82f2b0b97b36ee3fcddf0f0780a9a0825d52fec3 v6.15-rc6
> ---
> drivers/cxl/core/features.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c
> index 1498e2369c37..2d3a6d36a761 100644
> --- a/drivers/cxl/core/features.c
> +++ b/drivers/cxl/core/features.c
> @@ -416,14 +416,6 @@ static void *cxlctl_get_supported_features(struct cxl_features_state *cxlfs,
>
> rpc_out->size = struct_size(feat_out, ents, requested);
> feat_out = &rpc_out->get_sup_feats_out;
> - if (requested == 0) {
> - feat_out->num_entries = cpu_to_le16(requested);
> - feat_out->supported_feats =
> - cpu_to_le16(cxlfs->entries->num_features);
> - rpc_out->retval = CXL_MBOX_CMD_RC_SUCCESS;
> - *out_len = out_size;
> - return no_free_ptr(rpc_out);
> - }
>
> for (i = start, pos = &feat_out->ents[0];
> i < cxlfs->entries->num_features; i++, pos++) {
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] cxl/feature: Remove redundant code of get supported features
2025-05-16 14:32 [PATCH 1/1] cxl/feature: Remove redundant code of get supported features Li Ming
2025-05-16 15:24 ` Dave Jiang
@ 2025-05-19 15:33 ` Jonathan Cameron
2025-05-19 16:12 ` Dave Jiang
2025-05-19 22:08 ` Fan Ni
3 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2025-05-19 15:33 UTC (permalink / raw)
To: Li Ming
Cc: dave, dave.jiang, alison.schofield, vishal.l.verma, ira.weiny,
dan.j.williams, linux-cxl, linux-kernel
On Fri, 16 May 2025 22:32:20 +0800
Li Ming <ming.li@zohomail.com> wrote:
> In cxlctl_get_supported_features(), there is a code block that handles
> the case where the requested is equal to 0. But the code following the
> code block can also handle this situation. So the code block is not
> needed.
>
> Signed-off-by: Li Ming <ming.li@zohomail.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] cxl/feature: Remove redundant code of get supported features
2025-05-16 14:32 [PATCH 1/1] cxl/feature: Remove redundant code of get supported features Li Ming
2025-05-16 15:24 ` Dave Jiang
2025-05-19 15:33 ` Jonathan Cameron
@ 2025-05-19 16:12 ` Dave Jiang
2025-05-19 22:08 ` Fan Ni
3 siblings, 0 replies; 5+ messages in thread
From: Dave Jiang @ 2025-05-19 16:12 UTC (permalink / raw)
To: Li Ming, dave, jonathan.cameron, alison.schofield, vishal.l.verma,
ira.weiny, dan.j.williams
Cc: linux-cxl, linux-kernel
On 5/16/25 7:32 AM, Li Ming wrote:
> In cxlctl_get_supported_features(), there is a code block that handles
> the case where the requested is equal to 0. But the code following the
> code block can also handle this situation. So the code block is not
> needed.
>
> Signed-off-by: Li Ming <ming.li@zohomail.com>
Applied to cxl/next
> ---
> base-commit: 82f2b0b97b36ee3fcddf0f0780a9a0825d52fec3 v6.15-rc6
> ---
> drivers/cxl/core/features.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c
> index 1498e2369c37..2d3a6d36a761 100644
> --- a/drivers/cxl/core/features.c
> +++ b/drivers/cxl/core/features.c
> @@ -416,14 +416,6 @@ static void *cxlctl_get_supported_features(struct cxl_features_state *cxlfs,
>
> rpc_out->size = struct_size(feat_out, ents, requested);
> feat_out = &rpc_out->get_sup_feats_out;
> - if (requested == 0) {
> - feat_out->num_entries = cpu_to_le16(requested);
> - feat_out->supported_feats =
> - cpu_to_le16(cxlfs->entries->num_features);
> - rpc_out->retval = CXL_MBOX_CMD_RC_SUCCESS;
> - *out_len = out_size;
> - return no_free_ptr(rpc_out);
> - }
>
> for (i = start, pos = &feat_out->ents[0];
> i < cxlfs->entries->num_features; i++, pos++) {
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] cxl/feature: Remove redundant code of get supported features
2025-05-16 14:32 [PATCH 1/1] cxl/feature: Remove redundant code of get supported features Li Ming
` (2 preceding siblings ...)
2025-05-19 16:12 ` Dave Jiang
@ 2025-05-19 22:08 ` Fan Ni
3 siblings, 0 replies; 5+ messages in thread
From: Fan Ni @ 2025-05-19 22:08 UTC (permalink / raw)
To: Li Ming
Cc: dave, jonathan.cameron, dave.jiang, alison.schofield,
vishal.l.verma, ira.weiny, dan.j.williams, linux-cxl,
linux-kernel
On Fri, May 16, 2025 at 10:32:20PM +0800, Li Ming wrote:
> In cxlctl_get_supported_features(), there is a code block that handles
> the case where the requested is equal to 0. But the code following the
> code block can also handle this situation. So the code block is not
> needed.
>
> Signed-off-by: Li Ming <ming.li@zohomail.com>
> ---
Reviewed-by: Fan Ni <fan.ni@samsung.com>
> base-commit: 82f2b0b97b36ee3fcddf0f0780a9a0825d52fec3 v6.15-rc6
> ---
> drivers/cxl/core/features.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c
> index 1498e2369c37..2d3a6d36a761 100644
> --- a/drivers/cxl/core/features.c
> +++ b/drivers/cxl/core/features.c
> @@ -416,14 +416,6 @@ static void *cxlctl_get_supported_features(struct cxl_features_state *cxlfs,
>
> rpc_out->size = struct_size(feat_out, ents, requested);
> feat_out = &rpc_out->get_sup_feats_out;
> - if (requested == 0) {
> - feat_out->num_entries = cpu_to_le16(requested);
> - feat_out->supported_feats =
> - cpu_to_le16(cxlfs->entries->num_features);
> - rpc_out->retval = CXL_MBOX_CMD_RC_SUCCESS;
> - *out_len = out_size;
> - return no_free_ptr(rpc_out);
> - }
>
> for (i = start, pos = &feat_out->ents[0];
> i < cxlfs->entries->num_features; i++, pos++) {
> --
> 2.34.1
>
--
Fan Ni
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-05-19 22:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-16 14:32 [PATCH 1/1] cxl/feature: Remove redundant code of get supported features Li Ming
2025-05-16 15:24 ` Dave Jiang
2025-05-19 15:33 ` Jonathan Cameron
2025-05-19 16:12 ` Dave Jiang
2025-05-19 22:08 ` Fan Ni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox