From: Al Viro <viro@zeniv.linux.org.uk>
To: Arrsh Khusaria <arrshk01@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixed spacing errors in drivers/staging/fbtft/fbtft-bus.c
Date: Sun, 22 Jun 2025 23:43:27 +0100 [thread overview]
Message-ID: <20250622224327.GY1880847@ZenIV> (raw)
In-Reply-To: <CAC6rj2wiGOWUyhhGDRA-U8i=ZToorF4o6hwFeuC3RBDZ+rtoJQ@mail.gmail.com>
On Mon, Jun 23, 2025 at 03:50:24AM +0530, Arrsh Khusaria wrote:
> Hi,
> This patch fixes spacing issues in drivers/staging/foo/foo.c,
> such as spacing before parentheses and indentation, to comply with the
> kernel coding style guidelines.
>
> There are no functional changes.
>
> This is my first kernel patch. Please let me know if anything needs to be
> improved.
Er... Trying to compile the result, perhaps?
> Removed unnecessary whitespace and trailing comma inside a function
> parameter list, as reported by checkpatch.pl. No functional changes.
... and not treating the output of checkpatch.pl as unfallible oracle.
Seriously, try to build the resulting tree and see what happens.
prev parent reply other threads:[~2025-06-22 22:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-22 22:20 [PATCH] Fixed spacing errors in drivers/staging/fbtft/fbtft-bus.c Arrsh Khusaria
2025-06-22 22:43 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250622224327.GY1880847@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=arrshk01@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox