[PATCH] Fixed spacing errors in drivers/staging/fbtft/fbtft-bus.c

[PATCH] Fixed spacing errors in drivers/staging/fbtft/fbtft-bus.c

[Arrsh Khusaria]

[-- Attachment #1.1: Type: text/plain, Size: 303 bytes --]

Hi,
This patch fixes spacing issues in drivers/staging/foo/foo.c,
such as spacing before parentheses and indentation, to comply with the
kernel coding style guidelines.

There are no functional changes.

This is my first kernel patch. Please let me know if anything needs to be
improved.

Thanks,
Arrsh

[-- Attachment #1.2: Type: text/html, Size: 366 bytes --]

[-- Attachment #2: 0001-staging-fbtft-fix-spacing-issue-in-fbtft-bus.c.patch --]
[-- Type: text/x-patch, Size: 1240 bytes --]

From d553f5353f65524ed75d16fff757aaf6f0d5eef6 Mon Sep 17 00:00:00 2001
From: Arrsh Khusaria <arrshk01@gmail.com>
Date: Mon, 23 Jun 2025 02:07:14 +0530
Subject: [PATCH] staging: fbtft: fix spacing issue in fbtft-bus.c

Removed unnecessary whitespace and trailing comma inside a function
parameter list, as reported by checkpatch.pl. No functional changes.

Signed-off-by: Arrsh Khusaria <arrshk01@gmail.com>
---
 drivers/staging/fbtft/fbtft-bus.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 30e436ff19e4..409770891c54 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -62,9 +62,9 @@ out:									      \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
 
 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
 {
-- 
2.50.0

Re: [PATCH] Fixed spacing errors in drivers/staging/fbtft/fbtft-bus.c

[Al Viro]

On Mon, Jun 23, 2025 at 03:50:24AM +0530, Arrsh Khusaria wrote:
> Hi,
> This patch fixes spacing issues in drivers/staging/foo/foo.c,
> such as spacing before parentheses and indentation, to comply with the
> kernel coding style guidelines.
> 
> There are no functional changes.
> 
> This is my first kernel patch. Please let me know if anything needs to be
> improved.

Er...  Trying to compile the result, perhaps?

> Removed unnecessary whitespace and trailing comma inside a function
> parameter list, as reported by checkpatch.pl. No functional changes.

... and not treating the output of checkpatch.pl as unfallible oracle.

Seriously, try to build the resulting tree and see what happens.