* Re: [PATCH] media: imx8mq-mipi-csi2: Fix error code in imx8mq_mipi_csi_parse_dt()
2025-06-25 15:22 [PATCH] media: imx8mq-mipi-csi2: Fix error code in imx8mq_mipi_csi_parse_dt() Dan Carpenter
@ 2025-06-25 15:27 ` Frank Li
2025-06-25 16:04 ` Rui Miguel Silva
2025-06-26 0:20 ` Laurent Pinchart
2 siblings, 0 replies; 7+ messages in thread
From: Frank Li @ 2025-06-25 15:27 UTC (permalink / raw)
To: Dan Carpenter
Cc: Rui Miguel Silva, Laurent Pinchart, Martin Kepplinger,
Purism Kernel Team, Mauro Carvalho Chehab, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Hans Verkuil, linux-media, imx, linux-arm-kernel, linux-kernel,
kernel-janitors
On Wed, Jun 25, 2025 at 10:22:32AM -0500, Dan Carpenter wrote:
> This was returning IS_ERR() where PTR_ERR() was intended.
Thank you fix this.
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
> Fixes: 642b70d526ab ("media: imx8mq-mipi-csi2: Add support for i.MX8QXP")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> index 6501843ae72d..3a4645f59a44 100644
> --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> @@ -966,7 +966,7 @@ static int imx8mq_mipi_csi_parse_dt(struct csi_state *state)
>
> base = devm_platform_ioremap_resource(to_platform_device(dev), 1);
> if (IS_ERR(base))
> - return dev_err_probe(dev, IS_ERR(base), "Missing CSR register\n");
> + return dev_err_probe(dev, PTR_ERR(base), "Missing CSR register\n");
>
> state->phy_gpr = devm_regmap_init_mmio(dev, base, ®map_config);
> if (IS_ERR(state->phy_gpr))
> --
> 2.47.2
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] media: imx8mq-mipi-csi2: Fix error code in imx8mq_mipi_csi_parse_dt()
2025-06-25 15:22 [PATCH] media: imx8mq-mipi-csi2: Fix error code in imx8mq_mipi_csi_parse_dt() Dan Carpenter
2025-06-25 15:27 ` Frank Li
@ 2025-06-25 16:04 ` Rui Miguel Silva
2025-06-26 0:20 ` Laurent Pinchart
2 siblings, 0 replies; 7+ messages in thread
From: Rui Miguel Silva @ 2025-06-25 16:04 UTC (permalink / raw)
To: Dan Carpenter, Frank Li, Rui Miguel Silva
Cc: Laurent Pinchart, Martin Kepplinger, Purism Kernel Team,
Mauro Carvalho Chehab, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Hans Verkuil, linux-media,
imx, linux-arm-kernel, linux-kernel, kernel-janitors
Hey Dan,
Thanks for the patch.
On Wed Jun 25, 2025 at 4:22 PM WEST, Dan Carpenter wrote:
> This was returning IS_ERR() where PTR_ERR() was intended.
>
> Fixes: 642b70d526ab ("media: imx8mq-mipi-csi2: Add support for i.MX8QXP")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Rui Miguel Silva <rui.silva@linaro.org>
Cheers,
Rui
> ---
> drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> index 6501843ae72d..3a4645f59a44 100644
> --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> @@ -966,7 +966,7 @@ static int imx8mq_mipi_csi_parse_dt(struct csi_state *state)
>
> base = devm_platform_ioremap_resource(to_platform_device(dev), 1);
> if (IS_ERR(base))
> - return dev_err_probe(dev, IS_ERR(base), "Missing CSR register\n");
> + return dev_err_probe(dev, PTR_ERR(base), "Missing CSR register\n");
>
> state->phy_gpr = devm_regmap_init_mmio(dev, base, ®map_config);
> if (IS_ERR(state->phy_gpr))
> --
> 2.47.2
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] media: imx8mq-mipi-csi2: Fix error code in imx8mq_mipi_csi_parse_dt()
2025-06-25 15:22 [PATCH] media: imx8mq-mipi-csi2: Fix error code in imx8mq_mipi_csi_parse_dt() Dan Carpenter
2025-06-25 15:27 ` Frank Li
2025-06-25 16:04 ` Rui Miguel Silva
@ 2025-06-26 0:20 ` Laurent Pinchart
2025-06-26 0:32 ` Dan Carpenter
2 siblings, 1 reply; 7+ messages in thread
From: Laurent Pinchart @ 2025-06-26 0:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: Frank Li, Rui Miguel Silva, Martin Kepplinger, Purism Kernel Team,
Mauro Carvalho Chehab, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Hans Verkuil, linux-media,
imx, linux-arm-kernel, linux-kernel, kernel-janitors
Hi Dan,
Thank you for the patch.
On Wed, Jun 25, 2025 at 10:22:32AM -0500, Dan Carpenter wrote:
> This was returning IS_ERR() where PTR_ERR() was intended.
>
> Fixes: 642b70d526ab ("media: imx8mq-mipi-csi2: Add support for i.MX8QXP")
I'll add a
Cc: stable@vger.kernel.org
to obey the media subsystem CI rules.
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> index 6501843ae72d..3a4645f59a44 100644
> --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
> @@ -966,7 +966,7 @@ static int imx8mq_mipi_csi_parse_dt(struct csi_state *state)
>
> base = devm_platform_ioremap_resource(to_platform_device(dev), 1);
> if (IS_ERR(base))
> - return dev_err_probe(dev, IS_ERR(base), "Missing CSR register\n");
> + return dev_err_probe(dev, PTR_ERR(base), "Missing CSR register\n");
>
> state->phy_gpr = devm_regmap_init_mmio(dev, base, ®map_config);
> if (IS_ERR(state->phy_gpr))
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] media: imx8mq-mipi-csi2: Fix error code in imx8mq_mipi_csi_parse_dt()
2025-06-26 0:20 ` Laurent Pinchart
@ 2025-06-26 0:32 ` Dan Carpenter
2025-06-26 8:30 ` Laurent Pinchart
0 siblings, 1 reply; 7+ messages in thread
From: Dan Carpenter @ 2025-06-26 0:32 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Frank Li, Rui Miguel Silva, Martin Kepplinger, Purism Kernel Team,
Mauro Carvalho Chehab, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Hans Verkuil, linux-media,
imx, linux-arm-kernel, linux-kernel, kernel-janitors
On Thu, Jun 26, 2025 at 03:20:53AM +0300, Laurent Pinchart wrote:
> Hi Dan,
>
> Thank you for the patch.
>
> On Wed, Jun 25, 2025 at 10:22:32AM -0500, Dan Carpenter wrote:
> > This was returning IS_ERR() where PTR_ERR() was intended.
> >
> > Fixes: 642b70d526ab ("media: imx8mq-mipi-csi2: Add support for i.MX8QXP")
>
> I'll add a
>
> Cc: stable@vger.kernel.org
>
> to obey the media subsystem CI rules.
>
Wait, what? The original commit hasn't hit Linus's tree and it's
not marked for stable either.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] media: imx8mq-mipi-csi2: Fix error code in imx8mq_mipi_csi_parse_dt()
2025-06-26 0:32 ` Dan Carpenter
@ 2025-06-26 8:30 ` Laurent Pinchart
2025-07-03 18:02 ` Laurent Pinchart
0 siblings, 1 reply; 7+ messages in thread
From: Laurent Pinchart @ 2025-06-26 8:30 UTC (permalink / raw)
To: Dan Carpenter
Cc: Frank Li, Rui Miguel Silva, Martin Kepplinger, Purism Kernel Team,
Mauro Carvalho Chehab, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Hans Verkuil, linux-media,
imx, linux-arm-kernel, linux-kernel, kernel-janitors
On Thu, Jun 26, 2025 at 03:32:50AM +0300, Dan Carpenter wrote:
> On Thu, Jun 26, 2025 at 03:20:53AM +0300, Laurent Pinchart wrote:
> > On Wed, Jun 25, 2025 at 10:22:32AM -0500, Dan Carpenter wrote:
> > > This was returning IS_ERR() where PTR_ERR() was intended.
> > >
> > > Fixes: 642b70d526ab ("media: imx8mq-mipi-csi2: Add support for i.MX8QXP")
> >
> > I'll add a
> >
> > Cc: stable@vger.kernel.org
> >
> > to obey the media subsystem CI rules.
>
> Wait, what? The original commit hasn't hit Linus's tree and it's
> not marked for stable either.
I'm personally not in favour of adding Cc: stable on all patches that
have a Fixes: line. I'll let Mauro defend the rule, and I'm happy to
drop the Cc line and fix the CI.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] media: imx8mq-mipi-csi2: Fix error code in imx8mq_mipi_csi_parse_dt()
2025-06-26 8:30 ` Laurent Pinchart
@ 2025-07-03 18:02 ` Laurent Pinchart
0 siblings, 0 replies; 7+ messages in thread
From: Laurent Pinchart @ 2025-07-03 18:02 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Frank Li, Rui Miguel Silva, Dan Carpenter, Martin Kepplinger,
Purism Kernel Team, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Hans Verkuil, linux-media,
imx, linux-arm-kernel, linux-kernel, kernel-janitors
On Thu, Jun 26, 2025 at 11:30:18AM +0300, Laurent Pinchart wrote:
> On Thu, Jun 26, 2025 at 03:32:50AM +0300, Dan Carpenter wrote:
> > On Thu, Jun 26, 2025 at 03:20:53AM +0300, Laurent Pinchart wrote:
> > > On Wed, Jun 25, 2025 at 10:22:32AM -0500, Dan Carpenter wrote:
> > > > This was returning IS_ERR() where PTR_ERR() was intended.
> > > >
> > > > Fixes: 642b70d526ab ("media: imx8mq-mipi-csi2: Add support for i.MX8QXP")
> > >
> > > I'll add a
> > >
> > > Cc: stable@vger.kernel.org
> > >
> > > to obey the media subsystem CI rules.
> >
> > Wait, what? The original commit hasn't hit Linus's tree and it's
> > not marked for stable either.
>
> I'm personally not in favour of adding Cc: stable on all patches that
> have a Fixes: line. I'll let Mauro defend the rule, and I'm happy to
> drop the Cc line and fix the CI.
Mauro, could you please tell what would be your preference ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 7+ messages in thread