public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Alireza Sanaee <alireza.sanaee@huawei.com>
Cc: <mark.rutland@arm.com>, <robh@kernel.org>,
	<coresight@lists.linaro.org>, <devicetree@vger.kernel.org>,
	<dianders@chromium.org>, <james.clark@linaro.org>,
	<krzk@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-perf-users@vger.kernel.org>, <linuxarm@huawei.com>,
	<mike.leach@linaro.org>, <ruanjinjie@huawei.com>,
	<saravanak@google.com>, <shameerali.kolothum.thodi@huawei.com>,
	<suzuki.poulose@arm.com>
Subject: Re: [PATCH 4/5] coresight: Use of_cpu_phandle_to_id for grabbing CPU id
Date: Tue, 8 Jul 2025 09:37:11 +0100	[thread overview]
Message-ID: <20250708093711.0000295d@huawei.com> (raw)
In-Reply-To: <20250707150414.620-5-alireza.sanaee@huawei.com>

On Mon, 7 Jul 2025 16:04:13 +0100
Alireza Sanaee <alireza.sanaee@huawei.com> wrote:

> Use the newly created API to grab CPU id.
> 
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
> ---
>  drivers/hwtracing/coresight/coresight-platform.c | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c
> index 8192ba3279f0..f032fdbe959b 100644
> --- a/drivers/hwtracing/coresight/coresight-platform.c
> +++ b/drivers/hwtracing/coresight/coresight-platform.c
> @@ -167,19 +167,9 @@ of_coresight_get_output_ports_node(const struct device_node *node)
>  
>  static int of_coresight_get_cpu(struct device *dev)
>  {
> -	int cpu;
> -	struct device_node *dn;
> -
> -	if (!dev->of_node)
> -		return -ENODEV;
> -
> -	dn = of_parse_phandle(dev->of_node, "cpu", 0);
> -	if (!dn)
> -		return -ENODEV;
> -
> -	cpu = of_cpu_node_to_id(dn);
> +	struct device_node *dn = NULL;
> +	int cpu = of_cpu_phandle_to_id(dev->of_node, &dn, 0);
>  	of_node_put(dn);
> -
	Again, allowing for NULL parameter gives you simply

	return of_cpu_phandle_to_id(dev->of_node, NULL, 0);

>  	return cpu;
>  }
>  


  reply	other threads:[~2025-07-08  8:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07 15:04 [PATCH 0/5] Refactoring finding CPU phandles in DT Alireza Sanaee
2025-07-07 15:04 ` [PATCH 1/5] of: add infra for finding CPU id from phandle Alireza Sanaee
2025-07-08  8:26   ` Jonathan Cameron
2025-07-07 15:04 ` [PATCH 2/5] arch_topology: update CPU map to use the new API Alireza Sanaee
2025-07-08  6:29   ` Krzysztof Kozlowski
2025-07-08  8:22     ` Jonathan Cameron
2025-07-08  8:26       ` Krzysztof Kozlowski
2025-07-08  8:31   ` Jonathan Cameron
2025-07-07 15:04 ` [PATCH 3/5] coresight: cti: Use of_cpu_phandle_to_id for grabbing CPU id Alireza Sanaee
2025-07-08  8:36   ` Jonathan Cameron
2025-07-07 15:04 ` [PATCH 4/5] coresight: " Alireza Sanaee
2025-07-08  8:37   ` Jonathan Cameron [this message]
2025-07-07 15:04 ` [PATCH 5/5] perf/arm-dsu: refactor cpu id retrieval via new API of_cpu_phandle_to_id Alireza Sanaee
2025-07-08  8:38   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250708093711.0000295d@huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=alireza.sanaee@huawei.com \
    --cc=coresight@lists.linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=james.clark@linaro.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=robh@kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=saravanak@google.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox