* [PATCH] clk: rockchip: Fix error pointer check after rockchip_clk_register_gate_link()
@ 2025-08-05 3:03 Miaoqian Lin
2026-01-09 20:42 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2025-08-05 3:03 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Heiko Stuebner,
Sebastian Reichel, linux-clk, linux-arm-kernel, linux-rockchip,
linux-kernel
Cc: linmq006
Replace NULL check with IS_ERR_OR_NULL() check after calling
rockchip_clk_register_gate_link() since this function
returns error pointers (ERR_PTR).
Fixes: c62fa612cfa6 ("clk: rockchip: implement linked gate clock support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/clk/rockchip/clk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
index 19caf26c991b..2d30b1e24f01 100644
--- a/drivers/clk/rockchip/clk.c
+++ b/drivers/clk/rockchip/clk.c
@@ -693,7 +693,7 @@ void rockchip_clk_register_late_branches(struct device *dev,
break;
}
- if (!pdev)
+ if (IS_ERR_OR_NULL(pdev))
dev_err(dev, "failed to register device for clock %s\n", list->name);
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: rockchip: Fix error pointer check after rockchip_clk_register_gate_link()
2025-08-05 3:03 [PATCH] clk: rockchip: Fix error pointer check after rockchip_clk_register_gate_link() Miaoqian Lin
@ 2026-01-09 20:42 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2026-01-09 20:42 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Sebastian Reichel, linux-clk,
linux-arm-kernel, linux-rockchip, linux-kernel, Miaoqian Lin
Cc: Heiko Stuebner
On Tue, 05 Aug 2025 07:03:58 +0400, Miaoqian Lin wrote:
> Replace NULL check with IS_ERR_OR_NULL() check after calling
> rockchip_clk_register_gate_link() since this function
> returns error pointers (ERR_PTR).
>
>
Applied, thanks!
[1/1] clk: rockchip: Fix error pointer check after rockchip_clk_register_gate_link()
commit: a8d722f03923b1c6166d39482c6df8f017e185d9
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-09 20:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-05 3:03 [PATCH] clk: rockchip: Fix error pointer check after rockchip_clk_register_gate_link() Miaoqian Lin
2026-01-09 20:42 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox