public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Michal Pecio <michal.pecio@gmail.com>
Cc: Ricardo Ribalda <ribalda@chromium.org>,
	Hans de Goede <hansg@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: uvcvideo: Shorten the transfer size non compliance message
Date: Mon, 8 Sep 2025 10:35:44 +0200	[thread overview]
Message-ID: <20250908083544.GA23493@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20250904102405.3109bfa6.michal.pecio@gmail.com>

On Thu, Sep 04, 2025 at 10:24:05AM +0200, Michal Pecio wrote:
> On Thu, 4 Sep 2025 09:20:31 +0200, Ricardo Ribalda wrote:
> > Hi Michal
> > 
> > I like the new writing :)
> > 
> > On Thu, 4 Sept 2025 at 08:14, Michal Pecio <michal.pecio@gmail.com> wrote:
> > >
> > > This message is much longer than others and doesn't fit even in a 160
> > > column window when printed, despite providing little real information.
> > >
> > > Also replace 'transmission' with 'transfer' because that's the actual
> > > name and 'max packet' with 'limit' because it isn't same thing with
> > > isochronus endpoints. Remove cryptic abbreviations like 'ep'.
> > >  
> > Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
> 
> Thank you.
> 
> On second thought, I'm not sure if those brackets look good here:
> 
> [ 2410.688715] uvcvideo 11-1:1.1: UVC non compliance: Reducing max payload transfer size (32764) to fit endpoint limit (20480).
> 
> but I sent the patch already. If you think it would be better without
> them, please feel free to tweak the patch or ask for v2. If not, meh.

I like th enew message.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2025-09-08  8:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-04  6:14 [PATCH] media: uvcvideo: Shorten the transfer size non compliance message Michal Pecio
2025-09-04  7:20 ` Ricardo Ribalda
2025-09-04  8:24   ` Michal Pecio
2025-09-08  8:35     ` Laurent Pinchart [this message]
2025-09-08  8:36 ` Laurent Pinchart
2025-09-08  9:57   ` Michal Pecio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250908083544.GA23493@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=michal.pecio@gmail.com \
    --cc=ribalda@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox