From: Michal Pecio <michal.pecio@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: uvcvideo: Shorten the transfer size non compliance message
Date: Mon, 8 Sep 2025 11:57:32 +0200 [thread overview]
Message-ID: <20250908115732.04e84058.michal.pecio@gmail.com> (raw)
In-Reply-To: <20250908083655.GB23493@pendragon.ideasonboard.com>
On Mon, 8 Sep 2025 10:36:55 +0200, Laurent Pinchart wrote:
> On Thu, Sep 04, 2025 at 08:14:29AM +0200, Michal Pecio wrote:
> > This message is much longer than others and doesn't fit even in a 160
> > column window when printed, despite providing little real information.
> >
> > Also replace 'transmission' with 'transfer' because that's the actual
> > name and 'max packet' with 'limit' because it isn't same thing with
> > isochronus endpoints. Remove cryptic abbreviations like 'ep'.
> >
> > Signed-off-by: Michal Pecio <michal.pecio@gmail.com>
> > ---
> >
> > By the way, this hack doesn't help much in the opposite case:
> > dwMaxPayloadTransferSize is right, but EP descriptors are a mess.
>
> Have you encountered such devices ?
Yes, it sometimes reports bad 'mult' in EP descriptors, which leaves
them with insufficient BW for some video modes. Can be fixed with the
usual "turn it off, turn it on again".
I frankly haven't bothered trying what would happen if I override mult
in USB core and I think it would be crazy to send that upstream anyway.
Before that patch, it would simply fail with "no fast enough alt
setting" and -EIO or some such seen by userspace. Now it produces
truncated frames. But also nothing worse than that, so it's fine.
Regards,
Michal
prev parent reply other threads:[~2025-09-08 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 6:14 [PATCH] media: uvcvideo: Shorten the transfer size non compliance message Michal Pecio
2025-09-04 7:20 ` Ricardo Ribalda
2025-09-04 8:24 ` Michal Pecio
2025-09-08 8:35 ` Laurent Pinchart
2025-09-08 8:36 ` Laurent Pinchart
2025-09-08 9:57 ` Michal Pecio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250908115732.04e84058.michal.pecio@gmail.com \
--to=michal.pecio@gmail.com \
--cc=hansg@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox