[PATCH fwctl 0/2] fwctl/mlx5: Add few new FW rpc commands

[PATCH fwctl 0/2] fwctl/mlx5: Add few new FW rpc commands

[Saeed Mahameed]

From: Saeed Mahameed <saeedm@nvidia.com>

Hi Jason and Dave,

This series adds few new commands to fwctl/mlx5 driver:
1) Adjacent function query commands and their scope
2) Modify congestion status command

For more details please see each patch description.

Thanks,
Saeed

Avihai Horon (1):
  fwctl/mlx5: Allow MODIFY_CONG_STATUS command

Saeed Mahameed (1):
  fwctl/mlx5: Add Adjacent function query commands and their scope

 drivers/fwctl/mlx5/main.c | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.51.0

[PATCH fwctl 1/2] fwctl/mlx5: Allow MODIFY_CONG_STATUS command

[Saeed Mahameed]

From: Avihai Horon <avihaih@nvidia.com>

MODIFY_CONG_STATUS command is used to enable or disable congestion
control according to a given priority and protocol.

Add MODIFY_CONG_STATUS to the allowed commands under configuration
scope.

Change-Id: I6099206ca683de5173fe74fe56f63994f1c4c911
Signed-off-by: Avihai Horon <avihaih@nvidia.com>
---
 drivers/fwctl/mlx5/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/fwctl/mlx5/main.c b/drivers/fwctl/mlx5/main.c
index f93aa0cecdb9..7f3a1a9f7224 100644
--- a/drivers/fwctl/mlx5/main.c
+++ b/drivers/fwctl/mlx5/main.c
@@ -188,6 +188,7 @@ static bool mlx5ctl_validate_rpc(const void *in, enum fwctl_rpc_scope scope)
 	 * filter commands manually for now.
 	 */
 	switch (opcode) {
+	case MLX5_CMD_OP_MODIFY_CONG_STATUS:
 	case MLX5_CMD_OP_POSTPONE_CONNECTED_QP_TIMEOUT:
 	case MLX5_CMD_OP_QUERY_ADAPTER:
 	case MLX5_CMD_OP_QUERY_ESW_FUNCTIONS:
-- 
2.51.0

[PATCH fwctl 2/2] fwctl/mlx5: Add Adjacent function query commands and their scope

[Saeed Mahameed]

From: Saeed Mahameed <saeedm@nvidia.com>

MLX5_CMD_OP_QUERY_ADJACENT_FUNCTIONS_ID:
 - Query Adjacent functions (PFs/VFs) of the function calling FW.

MLX5_CMD_OP_DELEGATE_VHCA_MANAGEMENT:
 - Delegates own VFs to be managed/seen by other adjacent PFs

MLX5_CMD_OP_QUERY_DELEGATED_VHCA:
 - Query current function delegation state.

Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
 drivers/fwctl/mlx5/main.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/fwctl/mlx5/main.c b/drivers/fwctl/mlx5/main.c
index 7f3a1a9f7224..5b453742a5c5 100644
--- a/drivers/fwctl/mlx5/main.c
+++ b/drivers/fwctl/mlx5/main.c
@@ -58,6 +58,9 @@ enum {
 	MLX5_CMD_OP_QUERY_DC_CNAK_TRACE = 0x716,
 	MLX5_CMD_OP_QUERY_NVMF_BACKEND_CONTROLLER = 0x722,
 	MLX5_CMD_OP_QUERY_NVMF_NAMESPACE_CONTEXT = 0x728,
+	MLX5_CMD_OP_QUERY_ADJACENT_FUNCTIONS_ID = 0x730,
+	MLX5_CMD_OP_DELEGATE_VHCA_MANAGEMENT = 0x731,
+	MLX5_CMD_OP_QUERY_DELEGATED_VHCA = 0x732,
 	MLX5_CMD_OP_QUERY_BURST_SIZE = 0x813,
 	MLX5_CMD_OP_QUERY_DIAGNOSTIC_PARAMS = 0x819,
 	MLX5_CMD_OP_SET_DIAGNOSTIC_PARAMS = 0x820,
@@ -197,6 +200,7 @@ static bool mlx5ctl_validate_rpc(const void *in, enum fwctl_rpc_scope scope)
 	case MLX5_CMD_OP_QUERY_OTHER_HCA_CAP:
 	case MLX5_CMD_OP_QUERY_ROCE_ADDRESS:
 	case MLX5_CMD_OPCODE_QUERY_VUID:
+	case MLX5_CMD_OP_DELEGATE_VHCA_MANAGEMENT:
 	/*
 	 * FW limits SET_HCA_CAP on the tools UID to only the other function
 	 * mode which is used for function pre-configuration
@@ -282,6 +286,8 @@ static bool mlx5ctl_validate_rpc(const void *in, enum fwctl_rpc_scope scope)
 	case MLX5_CMD_OP_QUERY_XRQ:
 	case MLX5_CMD_OP_USER_QUERY_XRQ_DC_PARAMS_ENTRY:
 	case MLX5_CMD_OP_USER_QUERY_XRQ_ERROR_PARAMS:
+	case MLX5_CMD_OP_QUERY_ADJACENT_FUNCTIONS_ID:
+	case MLX5_CMD_OP_QUERY_DELEGATED_VHCA:
 		return scope >= FWCTL_RPC_DEBUG_READ_ONLY;
 
 	case MLX5_CMD_OP_SET_DIAGNOSTIC_PARAMS:
-- 
2.51.0

Re: [PATCH fwctl 0/2] fwctl/mlx5: Add few new FW rpc commands

[Dave Jiang]

On 9/8/25 9:52 AM, Saeed Mahameed wrote:
> From: Saeed Mahameed <saeedm@nvidia.com>
> 
> Hi Jason and Dave,
> 
> This series adds few new commands to fwctl/mlx5 driver:
> 1) Adjacent function query commands and their scope
> 2) Modify congestion status command
> 
> For more details please see each patch description.
> 
> Thanks,
> Saeed
> 
> Avihai Horon (1):
>   fwctl/mlx5: Allow MODIFY_CONG_STATUS command
> 
> Saeed Mahameed (1):
>   fwctl/mlx5: Add Adjacent function query commands and their scope
> 
>  drivers/fwctl/mlx5/main.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

Straight forward enough, mlx5 specific adds
Reviewed-by: Dave Jiang <dave.jiang@intel.com>

Re: [PATCH fwctl 1/2] fwctl/mlx5: Allow MODIFY_CONG_STATUS command

[Jason Gunthorpe]

On Mon, Sep 08, 2025 at 09:52:55AM -0700, Saeed Mahameed wrote:
> From: Avihai Horon <avihaih@nvidia.com>
> 
> MODIFY_CONG_STATUS command is used to enable or disable congestion
> control according to a given priority and protocol.
> 
> Add MODIFY_CONG_STATUS to the allowed commands under configuration
> scope.
> 
> Change-Id: I6099206ca683de5173fe74fe56f63994f1c4c911
> Signed-off-by: Avihai Horon <avihaih@nvidia.com>

You left a change id, I removed it

Jason

Re: [PATCH fwctl 0/2] fwctl/mlx5: Add few new FW rpc commands

[Jason Gunthorpe]

On Mon, Sep 08, 2025 at 09:52:54AM -0700, Saeed Mahameed wrote:
> From: Saeed Mahameed <saeedm@nvidia.com>
> 
> Hi Jason and Dave,
> 
> This series adds few new commands to fwctl/mlx5 driver:
> 1) Adjacent function query commands and their scope
> 2) Modify congestion status command
> 
> For more details please see each patch description.
> 
> Thanks,
> Saeed
> 
> Avihai Horon (1):
>   fwctl/mlx5: Allow MODIFY_CONG_STATUS command
> 
> Saeed Mahameed (1):
>   fwctl/mlx5: Add Adjacent function query commands and their scope

Applied thanks

Jason