From: Yiming Qian <qianym1996@gmail.com>
To: dan.carpenter@linaro.org
Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
qianym1996@gmail.com, sudipm.mukherjee@gmail.com,
teddy.wang@siliconmotion.com
Subject: [PATCH v2 1/2] staging: sm750fb: remove unnecessary volatile qualifiers
Date: Tue, 9 Sep 2025 14:01:29 +0800 [thread overview]
Message-ID: <20250909060130.12919-2-qianym1996@gmail.com> (raw)
In-Reply-To: <20250909060130.12919-1-qianym1996@gmail.com>
The use of 'volatile' for memory-mapped I/O pointers is discouraged
in the Linux kernel as per
Documentation/process/volatile-considered-harmful.rst.
This patch removes the unnecessary 'volatile' qualifiers from the
lynx_accel struct members, improving code quality and maintainability.
Signed-off-by: Yiming Qian <qianym1996@gmail.com>
---
drivers/staging/sm750fb/sm750.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index d7f40efe3..41f1fb390 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -50,9 +50,9 @@ struct init_status {
struct lynx_accel {
/* base virtual address of DPR registers */
- volatile unsigned char __iomem *dprBase;
+ unsigned char __iomem *dprBase;
/* base virtual address of de data port */
- volatile unsigned char __iomem *dpPortBase;
+ unsigned char __iomem *dpPortBase;
/* function pointers */
void (*de_init)(struct lynx_accel *accel);
@@ -128,7 +128,7 @@ struct lynx_cursor {
char __iomem *vstart;
int offset;
/* mmio addr of hw cursor */
- volatile char __iomem *mmio;
+ char __iomem *mmio;
};
struct lynxfb_crtc {
--
2.51.0
next prev parent reply other threads:[~2025-09-09 6:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 5:21 [PATCH] staging: sm750fb: fix coding style issues in sm750.h Yiming Qian
2025-09-08 5:45 ` Dan Carpenter
2025-09-09 6:01 ` [PATCH v2 0/2] " Yiming Qian
2025-09-09 6:01 ` Yiming Qian [this message]
2025-09-09 6:01 ` [PATCH v2 2/2] staging: sm750fb: rename snake case variables Yiming Qian
2025-09-09 7:54 ` [PATCH v2 0/2] fix coding style issues in sm750.h Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250909060130.12919-2-qianym1996@gmail.com \
--to=qianym1996@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox