From: Dan Carpenter <dan.carpenter@linaro.org>
To: Yiming Qian <qianym1996@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: fix coding style issues in sm750.h
Date: Mon, 8 Sep 2025 08:45:50 +0300 [thread overview]
Message-ID: <aL5tjv_2YkvHPs5C@stanley.mountain> (raw)
In-Reply-To: <20250908052133.8888-1-qianym1996@gmail.com>
On Mon, Sep 08, 2025 at 01:21:33PM +0800, Yiming Qian wrote:
> This patch addresses several coding style warnings
> reported by checkpatch.pl:
>
> 1. Replaces CamelCase variable names with snake_case:
> - dprBase -> dpr_base
> - dpPortBase -> dp_port_base
>
> 2. Removes unnecessary use of 'volatile' qualifier
> from the lynx_share_struct members.
>
> These changes improve code readability and maintain
> consistency with the kernel coding style guidelines.
> No functional changes are introduced.
>
> Signed-off-by: Yiming Qian <qianym1996@gmail.com>
You need to split this into "one thing per patch".
[patch 1] remove volatile
[patch 2] rename snake case variables
regards,
dan carpenter
next prev parent reply other threads:[~2025-09-08 5:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 5:21 [PATCH] staging: sm750fb: fix coding style issues in sm750.h Yiming Qian
2025-09-08 5:45 ` Dan Carpenter [this message]
2025-09-09 6:01 ` [PATCH v2 0/2] " Yiming Qian
2025-09-09 6:01 ` [PATCH v2 1/2] staging: sm750fb: remove unnecessary volatile qualifiers Yiming Qian
2025-09-09 6:01 ` [PATCH v2 2/2] staging: sm750fb: rename snake case variables Yiming Qian
2025-09-09 7:54 ` [PATCH v2 0/2] fix coding style issues in sm750.h Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aL5tjv_2YkvHPs5C@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=qianym1996@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox