From: Leo Yan <leo.yan@arm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Mao Jinlong <quic_jinlmao@quicinc.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/5] coresight: Explicitly use the parent device handler
Date: Thu, 11 Sep 2025 10:21:48 +0100 [thread overview]
Message-ID: <20250911092148.GC12516@e132581.arm.com> (raw)
In-Reply-To: <64186261-3e65-45b5-a68c-8ec236a75f2f@arm.com>
On Thu, Sep 11, 2025 at 09:52:20AM +0100, Suzuki Kuruppassery Poulose wrote:
[...]
> > @@ -1393,7 +1397,7 @@ struct coresight_device *coresight_register(struct coresight_desc *desc)
> > err_out:
> > /* Cleanup the connection information */
> > - coresight_release_platform_data(NULL, desc->dev, desc->pdata);
> > + coresight_release_platform_data(NULL, csdev->dev.parent, desc->pdata);
>
> This may be problematic, as the csdev could be NULL ?
Indeed. I will drop this change in next version.
Thanks,
Leo
next prev parent reply other threads:[~2025-09-11 9:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 15:41 [PATCH v1 0/5] coresight: Fix device registration and unregistration Leo Yan
2025-05-12 15:41 ` [PATCH v1 1/5] coresight: Correct sink ID map allocation failure handling Leo Yan
2025-05-12 15:41 ` [PATCH v1 2/5] coresight: Protect unregistration with mutex Leo Yan
2025-05-12 15:41 ` [PATCH v1 3/5] coresight: Explicitly use the parent device handler Leo Yan
2025-09-11 8:52 ` Suzuki K Poulose
2025-09-11 9:21 ` Leo Yan [this message]
2025-05-12 15:41 ` [PATCH v1 4/5] coresight: Separate failure and success flows Leo Yan
2025-09-11 10:03 ` Suzuki K Poulose
2025-05-12 15:41 ` [PATCH v1 5/5] coresight: Refine error handling for device registration Leo Yan
2025-09-11 10:20 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250911092148.GC12516@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=quic_jinlmao@quicinc.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox