* [PATCH] staging: fbtft/fb_ra8875: replace udelay with usleep_range
@ 2025-09-13 20:41 Shay Power
2025-09-14 13:16 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Shay Power @ 2025-09-13 20:41 UTC (permalink / raw)
To: linux-kernel; +Cc: andy, linux-fbdev, Shay Power
Signed-off-by: Shay Power <shaythomaspower@gmail.com>
---
drivers/staging/fbtft/fb_ra8875.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ra8875.c b/drivers/staging/fbtft/fb_ra8875.c
index 0ab1de6647d0..edd467c6bf1a 100644
--- a/drivers/staging/fbtft/fb_ra8875.c
+++ b/drivers/staging/fbtft/fb_ra8875.c
@@ -210,7 +210,7 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...)
}
len--;
- udelay(100);
+ usleep_range(100, 150);
if (len) {
buf = (u8 *)par->buf;
@@ -231,7 +231,7 @@ static void write_reg8_bus8(struct fbtft_par *par, int len, ...)
/* restore user spi-speed */
par->fbtftops.write = fbtft_write_spi;
- udelay(100);
+ usleep_range(100, 150);
}
static int write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t len)
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: fbtft/fb_ra8875: replace udelay with usleep_range
2025-09-13 20:41 [PATCH] staging: fbtft/fb_ra8875: replace udelay with usleep_range Shay Power
@ 2025-09-14 13:16 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2025-09-14 13:16 UTC (permalink / raw)
To: Shay Power; +Cc: linux-kernel, andy, linux-fbdev
On Sat, Sep 13, 2025 at 11:42 PM Shay Power <shaythomaspower@gmail.com> wrote:
You must provide a commit message explaining "why?".
...
> - udelay(100);
> + usleep_range(100, 150);
In both cases this, besides not using fsleep(), moves from atomic to
sleepable context. This is the must to be explained in the commit
message as this is the main point of the change AFAICS.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-14 13:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-13 20:41 [PATCH] staging: fbtft/fb_ra8875: replace udelay with usleep_range Shay Power
2025-09-14 13:16 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox