* [PATCH] drm/sched/tests: Remove relict of done_list
@ 2025-09-19 6:44 Philipp Stanner
2025-09-19 7:33 ` Tvrtko Ursulin
0 siblings, 1 reply; 3+ messages in thread
From: Philipp Stanner @ 2025-09-19 6:44 UTC (permalink / raw)
To: Matthew Brost, Danilo Krummrich, Philipp Stanner,
Christian König, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Tvrtko Ursulin,
Maíra Canal, Liao Yuanhong
Cc: dri-devel, linux-kernel
A rework of the scheduler unit tests removed the done_list. That list is
still mentioned in the mock test header.
Remove that relict.
Fixes: 4576de9b7977 ("drm/sched/tests: Implement cancel_job() callback")
Signed-off-by: Philipp Stanner <phasta@kernel.org>
---
drivers/gpu/drm/scheduler/tests/sched_tests.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/scheduler/tests/sched_tests.h b/drivers/gpu/drm/scheduler/tests/sched_tests.h
index 7f31d35780cc..553d45abd057 100644
--- a/drivers/gpu/drm/scheduler/tests/sched_tests.h
+++ b/drivers/gpu/drm/scheduler/tests/sched_tests.h
@@ -31,9 +31,8 @@
*
* @base: DRM scheduler base class
* @test: Backpointer to owning the kunit test case
- * @lock: Lock to protect the simulated @hw_timeline, @job_list and @done_list
+ * @lock: Lock to protect the simulated @hw_timeline and @job_list
* @job_list: List of jobs submitted to the mock GPU
- * @done_list: List of jobs completed by the mock GPU
* @hw_timeline: Simulated hardware timeline has a @context, @next_seqno and
* @cur_seqno for implementing a struct dma_fence signaling the
* simulated job completion.
--
2.49.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/sched/tests: Remove relict of done_list
2025-09-19 6:44 [PATCH] drm/sched/tests: Remove relict of done_list Philipp Stanner
@ 2025-09-19 7:33 ` Tvrtko Ursulin
2025-09-19 12:11 ` Philipp Stanner
0 siblings, 1 reply; 3+ messages in thread
From: Tvrtko Ursulin @ 2025-09-19 7:33 UTC (permalink / raw)
To: Philipp Stanner, Matthew Brost, Danilo Krummrich,
Christian König, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Maíra Canal,
Liao Yuanhong
Cc: dri-devel, linux-kernel
On 19/09/2025 07:44, Philipp Stanner wrote:
> A rework of the scheduler unit tests removed the done_list. That list is
> still mentioned in the mock test header.
>
> Remove that relict.
>
> Fixes: 4576de9b7977 ("drm/sched/tests: Implement cancel_job() callback")
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
> ---
> drivers/gpu/drm/scheduler/tests/sched_tests.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/tests/sched_tests.h b/drivers/gpu/drm/scheduler/tests/sched_tests.h
> index 7f31d35780cc..553d45abd057 100644
> --- a/drivers/gpu/drm/scheduler/tests/sched_tests.h
> +++ b/drivers/gpu/drm/scheduler/tests/sched_tests.h
> @@ -31,9 +31,8 @@
> *
> * @base: DRM scheduler base class
> * @test: Backpointer to owning the kunit test case
> - * @lock: Lock to protect the simulated @hw_timeline, @job_list and @done_list
> + * @lock: Lock to protect the simulated @hw_timeline and @job_list
> * @job_list: List of jobs submitted to the mock GPU
> - * @done_list: List of jobs completed by the mock GPU
> * @hw_timeline: Simulated hardware timeline has a @context, @next_seqno and
> * @cur_seqno for implementing a struct dma_fence signaling the
> * simulated job completion.
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/sched/tests: Remove relict of done_list
2025-09-19 7:33 ` Tvrtko Ursulin
@ 2025-09-19 12:11 ` Philipp Stanner
0 siblings, 0 replies; 3+ messages in thread
From: Philipp Stanner @ 2025-09-19 12:11 UTC (permalink / raw)
To: Tvrtko Ursulin, Philipp Stanner, Matthew Brost, Danilo Krummrich,
Christian König, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Maíra Canal,
Liao Yuanhong
Cc: dri-devel, linux-kernel
On Fri, 2025-09-19 at 08:33 +0100, Tvrtko Ursulin wrote:
>
> On 19/09/2025 07:44, Philipp Stanner wrote:
> > A rework of the scheduler unit tests removed the done_list. That list is
> > still mentioned in the mock test header.
> >
> > Remove that relict.
> >
> > Fixes: 4576de9b7977 ("drm/sched/tests: Implement cancel_job() callback")
> > Signed-off-by: Philipp Stanner <phasta@kernel.org>
> > ---
> > drivers/gpu/drm/scheduler/tests/sched_tests.h | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/scheduler/tests/sched_tests.h b/drivers/gpu/drm/scheduler/tests/sched_tests.h
> > index 7f31d35780cc..553d45abd057 100644
> > --- a/drivers/gpu/drm/scheduler/tests/sched_tests.h
> > +++ b/drivers/gpu/drm/scheduler/tests/sched_tests.h
> > @@ -31,9 +31,8 @@
> > *
> > * @base: DRM scheduler base class
> > * @test: Backpointer to owning the kunit test case
> > - * @lock: Lock to protect the simulated @hw_timeline, @job_list and @done_list
> > + * @lock: Lock to protect the simulated @hw_timeline and @job_list
> > * @job_list: List of jobs submitted to the mock GPU
> > - * @done_list: List of jobs completed by the mock GPU
> > * @hw_timeline: Simulated hardware timeline has a @context, @next_seqno and
> > * @cur_seqno for implementing a struct dma_fence signaling the
> > * simulated job completion.
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Applied to drm-misc-next
Thx
P.
>
> Regards,
>
> Tvrtko
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-19 12:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-19 6:44 [PATCH] drm/sched/tests: Remove relict of done_list Philipp Stanner
2025-09-19 7:33 ` Tvrtko Ursulin
2025-09-19 12:11 ` Philipp Stanner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox