The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: jpoimboe@kernel.org, rostedt@kernel.org
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: [PATCH 06/12] unwind: Fix unwind_deferred_request() vs NMI
Date: Wed, 24 Sep 2025 09:59:54 +0200	[thread overview]
Message-ID: <20250924080119.005422353@infradead.org> (raw)
In-Reply-To: 20250924075948.579302904@infradead.org

task_work_add(RWA_RESUME) isn't NMI-safe, use TWA_NMI_CURRENT when
used from NMI context.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 kernel/unwind/deferred.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

--- a/kernel/unwind/deferred.c
+++ b/kernel/unwind/deferred.c
@@ -231,6 +231,7 @@ void unwind_deferred_task_exit(struct ta
 int unwind_deferred_request(struct unwind_work *work, u64 *cookie)
 {
 	struct unwind_task_info *info = &current->unwind_info;
+	int twa_mode = TWA_RESUME;
 	unsigned long old, bits;
 	unsigned long bit;
 	int ret;
@@ -246,8 +247,11 @@ int unwind_deferred_request(struct unwin
 	 * Trigger a warning to make it obvious that an architecture
 	 * is using this in NMI when it should not be.
 	 */
-	if (WARN_ON_ONCE(!CAN_USE_IN_NMI && in_nmi()))
-		return -EINVAL;
+	if (in_nmi()) {
+		if (WARN_ON_ONCE(!CAN_USE_IN_NMI))
+			return -EINVAL;
+		twa_mode = TWA_NMI_CURRENT;
+	}
 
 	/* Do not allow cancelled works to request again */
 	bit = READ_ONCE(work->bit);
@@ -285,7 +289,7 @@ int unwind_deferred_request(struct unwin
 	}
 
 	/* The work has been claimed, now schedule it. */
-	ret = task_work_add(current, &info->work, TWA_RESUME);
+	ret = task_work_add(current, &info->work, twa_mode);
 
 	if (WARN_ON_ONCE(ret))
 		WRITE_ONCE(info->unwind_mask, 0);



  parent reply	other threads:[~2025-09-24  8:03 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-24  7:59 [PATCH 00/12] Various fixes and x86 support Peter Zijlstra
2025-09-24  7:59 ` [PATCH 01/12] task_work: Fix NMI race condition Peter Zijlstra
2025-10-01 15:31   ` Steven Rostedt
2025-10-29  9:36   ` [tip: perf/core] " tip-bot2 for Peter Zijlstra
2025-09-24  7:59 ` [PATCH 02/12] unwind: Shorten lines Peter Zijlstra
2025-10-01 15:32   ` Steven Rostedt
2025-10-29  9:36   ` [tip: perf/core] " tip-bot2 for Peter Zijlstra
2025-09-24  7:59 ` [PATCH 03/12] unwind: Add required include files Peter Zijlstra
2025-10-01 15:32   ` Steven Rostedt
2025-10-29  9:36   ` [tip: perf/core] " tip-bot2 for Peter Zijlstra
2025-09-24  7:59 ` [PATCH 04/12] unwind: Simplify unwind_reset_info() Peter Zijlstra
2025-10-01 15:33   ` Steven Rostedt
2025-10-29  9:36   ` [tip: perf/core] " tip-bot2 for Peter Zijlstra
2025-09-24  7:59 ` [PATCH 05/12] unwind: Add comment to unwind_deferred_task_exit() Peter Zijlstra
2025-10-01 15:35   ` Steven Rostedt
2025-10-20 10:16     ` Peter Zijlstra
2025-10-22 15:16       ` Steven Rostedt
2025-10-29  9:36   ` [tip: perf/core] " tip-bot2 for Peter Zijlstra
2025-09-24  7:59 ` Peter Zijlstra [this message]
2025-10-01 15:37   ` [PATCH 06/12] unwind: Fix unwind_deferred_request() vs NMI Steven Rostedt
2025-10-29  9:36   ` [tip: perf/core] " tip-bot2 for Peter Zijlstra
2025-09-24  7:59 ` [PATCH 07/12] unwind: Clarify calling context Peter Zijlstra
2025-10-01 15:38   ` Steven Rostedt
2025-10-29  9:36   ` [tip: perf/core] " tip-bot2 for Peter Zijlstra
2025-09-24  7:59 ` [PATCH 08/12] unwind: Simplify unwind_user_faultable() Peter Zijlstra
2025-10-01 15:40   ` Steven Rostedt
2025-10-20 10:17     ` Peter Zijlstra
2025-10-29  9:36   ` [tip: perf/core] " tip-bot2 for Peter Zijlstra
2025-09-24  7:59 ` [PATCH 09/12] unwind: Make unwind_task_info::unwind_mask consistent Peter Zijlstra
2025-10-01 15:47   ` Steven Rostedt
2025-10-20 10:20     ` Peter Zijlstra
2025-10-29  9:36   ` [tip: perf/core] " tip-bot2 for Peter Zijlstra
2025-09-24  7:59 ` [PATCH 10/12] unwind: Simplify unwind_user_next_fp() alignment check Peter Zijlstra
2025-10-01 15:55   ` Steven Rostedt
2025-10-20 10:28     ` Peter Zijlstra
2025-10-22 15:20       ` Steven Rostedt
2025-10-23  9:53         ` Peter Zijlstra
2025-10-29  9:36   ` [tip: perf/core] " tip-bot2 for Peter Zijlstra
2025-09-24  7:59 ` [PATCH 11/12] unwind: Implement compat fp unwind Peter Zijlstra
2025-10-17 15:47   ` Jens Remus
2025-10-20  9:16     ` Jens Remus
2025-10-20 10:39       ` Peter Zijlstra
2025-10-20 10:48         ` Peter Zijlstra
2025-10-22 15:23           ` Steven Rostedt
2025-10-24 13:45             ` Peter Zijlstra
2025-10-22 14:55         ` Jens Remus
2025-10-24 13:40           ` Peter Zijlstra
2025-10-20 10:38     ` Peter Zijlstra
2025-10-22 18:31   ` Steven Rostedt
2025-10-24 14:10     ` Peter Zijlstra
2025-10-24 14:16       ` Peter Zijlstra
2025-10-29  9:36   ` [tip: perf/core] " tip-bot2 for Peter Zijlstra
2025-09-24  8:00 ` [PATCH 12/12] unwind_user/x86: Enable frame pointer unwinding on x86 Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250924080119.005422353@infradead.org \
    --to=peterz@infradead.org \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox