Re: [PATCH 11/12] unwind: Implement compat fp unwind

[Jens Remus <jremus@linux.ibm.com>]

Hello Peter!

On 10/20/2025 12:39 PM, Peter Zijlstra wrote:
> On Mon, Oct 20, 2025 at 11:16:45AM +0200, Jens Remus wrote:
>> On 10/17/2025 5:47 PM, Jens Remus wrote:

>>> In SFrame the CFA, FP, and RA offsets are unscaled.  Would it be ok, if
>>> unwind user sframe would factor state->ws from those offset values?  What
>>> if they were not aligned?  unwind user sframe would then have to fail.
>>
>> Sorry that I did not immediately think about the most obvious solution
>> tho above issues:  to not factor out the word size from the frame CFA,
>> FP, and RA offsets.  What do you think about making the following
>> changes to this and giyour subsequent patch?  That would work nicely
>> with unwind user sframe.
> 
> 
> Yes, this should do nicely. I've made the changes, I'll do a test build
> and then push out to the robots.

Thanks!  Looking at your following updated patch I found that your
change from "pointer to const struct unwind_user_frame" to
"const struct unwind_user_frame" (done for obvious reasons) will require
unwind user sframe to undo this when refactoring unwind_user_next_fp()
into unwind_user_next_common().  Would that be the usual procedure or
could you leave it as "pointer to const struct unwind_user_frame" for
now?

https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?h=unwind/cleanup&id=f3624d64ba4862067b620fbd5bfbc0bfaf5368ae

Thanks and regards,
Jens
-- 
Jens Remus
Linux on Z Development (D3303)
+49-7031-16-1128 Office
jremus@de.ibm.com

IBM

IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/