* [PATCH v2] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
@ 2025-09-28 4:45 Eric Gonçalves
2025-09-28 6:11 ` Dmitry Baryshkov
2025-10-01 8:48 ` Konrad Dybcio
0 siblings, 2 replies; 4+ messages in thread
From: Eric Gonçalves @ 2025-09-28 4:45 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Conor Dooley, Krzysztof Kozlowski,
Rob Herring
Cc: devicetree, linux-arm-msm, linux-kernel
The S20 series has additional reserved pins for the fingerprint sensor,
GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
---
Changes in v2:
- Fixed the formatting of the <40 4> line
- Added Fixes tag
---
arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
index 96662bf9e527..a87e3d23e3e2 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
@@ -159,7 +159,8 @@ &pon_resin {
};
&tlmm {
- gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
+ gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
+ <40 4>, /* Unused */
};
&usb_1 {
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
2025-09-28 4:45 [PATCH v2] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins Eric Gonçalves
@ 2025-09-28 6:11 ` Dmitry Baryshkov
2025-09-28 7:21 ` Eric Gonçalves
2025-10-01 8:48 ` Konrad Dybcio
1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-09-28 6:11 UTC (permalink / raw)
To: Eric Gonçalves
Cc: Bjorn Andersson, Konrad Dybcio, Conor Dooley, Krzysztof Kozlowski,
Rob Herring, devicetree, linux-arm-msm, linux-kernel
On Sun, Sep 28, 2025 at 04:45:33AM +0000, Eric Gonçalves wrote:
> The S20 series has additional reserved pins for the fingerprint sensor,
> GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
>
> Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
> ---
> Changes in v2:
> - Fixed the formatting of the <40 4> line
> - Added Fixes tag
> ---
> arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> index 96662bf9e527..a87e3d23e3e2 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> @@ -159,7 +159,8 @@ &pon_resin {
> };
>
> &tlmm {
> - gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
> + gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
> + <40 4>, /* Unused */
This is still not aligned to the opening angle bracket. Could you please
recheck your setup?
> };
>
> &usb_1 {
> --
> 2.51.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
2025-09-28 6:11 ` Dmitry Baryshkov
@ 2025-09-28 7:21 ` Eric Gonçalves
0 siblings, 0 replies; 4+ messages in thread
From: Eric Gonçalves @ 2025-09-28 7:21 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Konrad Dybcio, Conor Dooley, Krzysztof Kozlowski,
Rob Herring, devicetree, linux-arm-msm, linux-kernel
On September 28, 2025 3:11:16 AM GMT-03:00, Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> wrote:
>On Sun, Sep 28, 2025 at 04:45:33AM +0000, Eric Gonçalves wrote:
>> The S20 series has additional reserved pins for the fingerprint sensor,
>> GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
>>
>> Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
>> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
>> ---
>> Changes in v2:
>> - Fixed the formatting of the <40 4> line
>> - Added Fixes tag
>> ---
>> arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> index 96662bf9e527..a87e3d23e3e2 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
>> @@ -159,7 +159,8 @@ &pon_resin {
>> };
>>
>> &tlmm {
>> - gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
>> + gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
>> + <40 4>, /* Unused */
>
>This is still not aligned to the opening angle bracket. Could you please
>recheck your setup?
Yeah, sorry, I had it set to 4 spaces still - I sent a v3.
>
>> };
>>
>> &usb_1 {
>> --
>> 2.51.0
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins
2025-09-28 4:45 [PATCH v2] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins Eric Gonçalves
2025-09-28 6:11 ` Dmitry Baryshkov
@ 2025-10-01 8:48 ` Konrad Dybcio
1 sibling, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2025-10-01 8:48 UTC (permalink / raw)
To: Eric Gonçalves, Bjorn Andersson, Konrad Dybcio, Conor Dooley,
Krzysztof Kozlowski, Rob Herring
Cc: devicetree, linux-arm-msm, linux-kernel
On 9/28/25 6:45 AM, Eric Gonçalves wrote:
> The S20 series has additional reserved pins for the fingerprint sensor,
> GPIO 20-23. Correct it by adding them into gpio-reserved-ranges.
>
> Fixes: 6657fe9e9f23 ("arm64: dts: qcom: add initial support for Samsung Galaxy S20 FE")
> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
> ---
> Changes in v2:
> - Fixed the formatting of the <40 4> line
> - Added Fixes tag
> ---
> arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> index 96662bf9e527..a87e3d23e3e2 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-samsung-common.dtsi
> @@ -159,7 +159,8 @@ &pon_resin {
> };
>
> &tlmm {
> - gpio-reserved-ranges = <40 4>; /* I2C (Unused) */
> + gpio-reserved-ranges = <20 4>, /* SPI (fingerprint scanner) */
> + <40 4>, /* Unused */
Please set your tab width to 8 :)
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-01 8:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-28 4:45 [PATCH v2] arm64: dts: qcom: sm8250-samsung-common: correct reserved pins Eric Gonçalves
2025-09-28 6:11 ` Dmitry Baryshkov
2025-09-28 7:21 ` Eric Gonçalves
2025-10-01 8:48 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox