From: rtapadia730@gmail.com
To: fdmanana@kernel.org
Cc: clm@fb.com, david.hunter.linux@gmail.com, dsterba@suse.com,
fdmanana@suse.com, khalid@kernel.org,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
rtapadia730@gmail.com, skhan@linuxfoundation.org
Subject: Re: [PATCH] btrfs: push memalloc_nofs_save/restore() out of alloc_bitmap()
Date: Fri, 3 Oct 2025 18:55:35 +0530 [thread overview]
Message-ID: <20251003132535.42760-1-rtapadia730@gmail.com> (raw)
In-Reply-To: <CAL3q7H6BQpWAtfkA+tnW-fBkdqSDb4udAeJvdgHfKSKfpYWAOA@mail.gmail.com>
Thank you for the review and explanation.
> We test btrfs with fstests. The sanity tests aren't enough, they are
> mostly to test internal functions.
> Please don't declare variables in the middle of the code.
> We always declare variables at the top of the current scope.
Okay I will remember this for future patches.
> Just fix the comment, removing the TODO and mention that the reason we
> can't recurse is because we are holding a transaction handle open - it
> doesn't matter if we are in critical section of a transaction commit
> or not - all it matters is that we are holding a transaction handle
> open, so a GFP_KERNEL allocation results in a deadlock if it recurses
> to the filesystem to commit the transaction.
I'll send a v2 patch that just removes TODO and update the comment for
clearity.
prev parent reply other threads:[~2025-10-03 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-02 11:54 [PATCH] btrfs: push memalloc_nofs_save/restore() out of alloc_bitmap() rtapadia730
2025-10-02 12:06 ` Filipe Manana
2025-10-03 13:25 ` rtapadia730 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251003132535.42760-1-rtapadia730@gmail.com \
--to=rtapadia730@gmail.com \
--cc=clm@fb.com \
--cc=david.hunter.linux@gmail.com \
--cc=dsterba@suse.com \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=khalid@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox