[PATCH] PCI: of: Downgrade error message on missing of_root node

[PATCH] PCI: of: Downgrade error message on missing of_root node

[Andrea della Porta]

When CONFIG_PCI_DYNAMIC_OF_NODES is enabled, an error message
is generated if no 'of_root' node is defined.

On DT-based systems, this cannot happen as a root DT node is
always present. On ACPI-based systems, this is not a true error
because a DT is not used.

Downgrade the pr_err() to pr_info().

Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
---
 drivers/pci/of.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index 3579265f1198..034486593210 100644
--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -775,7 +775,7 @@ void of_pci_make_host_bridge_node(struct pci_host_bridge *bridge)
 
 	/* Check if there is a DT root node to attach the created node */
 	if (!of_root) {
-		pr_err("of_root node is NULL, cannot create PCI host bridge node\n");
+		pr_info("of_root node is NULL, cannot create PCI host bridge node\n");
 		return;
 	}
 
-- 
2.35.3

Re: [PATCH] PCI: of: Downgrade error message on missing of_root node

[Bjorn Helgaas]

On Tue, Oct 21, 2025 at 05:32:19PM +0200, Andrea della Porta wrote:
> When CONFIG_PCI_DYNAMIC_OF_NODES is enabled, an error message
> is generated if no 'of_root' node is defined.
> 
> On DT-based systems, this cannot happen as a root DT node is
> always present. On ACPI-based systems, this is not a true error
> because a DT is not used.
> 
> Downgrade the pr_err() to pr_info().
> 
> Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> ---
>  drivers/pci/of.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/of.c b/drivers/pci/of.c
> index 3579265f1198..034486593210 100644
> --- a/drivers/pci/of.c
> +++ b/drivers/pci/of.c
> @@ -775,7 +775,7 @@ void of_pci_make_host_bridge_node(struct pci_host_bridge *bridge)
>  
>  	/* Check if there is a DT root node to attach the created node */
>  	if (!of_root) {
> -		pr_err("of_root node is NULL, cannot create PCI host bridge node\n");
> +		pr_info("of_root node is NULL, cannot create PCI host bridge node\n");

If we're going to see this message in the normal course of events on
ACPI systems, I think maybe we should reword it so it assumes less
context.  "of_root node" is low-level technical detail that doesn't
even make sense to me without digging into the code.