* [PATCH 0/2] arch/powerpc: Add missing includes
@ 2025-10-29 15:09 Thierry Reding
2025-10-29 15:09 ` [PATCH 1/2] arch/powerpc: Add missing linux/of.h include Thierry Reding
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thierry Reding @ 2025-10-29 15:09 UTC (permalink / raw)
To: Madhavan Srinivasan, Michael Ellerman
Cc: Nicholas Piggin, Christophe Leroy, Thomas Zimmermann,
linuxppc-dev, linux-kernel
From: Thierry Reding <treding@nvidia.com>
Hi,
I've recently been doing a few test builds for some of the more exotic
platforms out there for a patch series that I'm working on and ran into
some issues that seem to have been caused by the framebuffer include
rework. I see that Thomas did address some of those already, but it
looks like I've been running with slightly different configurations or
something that caused these additional ones to come up.
Given that theese seem to have been broken for more than a year and it's
not exactly clear which commit it caused, I didn't bother adding a Fixes
line, but still wanted to send these out in case we want to keep these
platforms building.
Thierry
Thierry Reding (2):
arch/powerpc: Add missing linux/of.h include
macintosh/via-pmu-backlight: Include uapi/linux/fb.h
arch/powerpc/platforms/powermac/backlight.c | 1 +
drivers/macintosh/via-pmu-backlight.c | 1 +
2 files changed, 2 insertions(+)
--
2.51.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH 1/2] arch/powerpc: Add missing linux/of.h include
2025-10-29 15:09 [PATCH 0/2] arch/powerpc: Add missing includes Thierry Reding
@ 2025-10-29 15:09 ` Thierry Reding
2025-10-29 15:09 ` [PATCH 2/2] macintosh/via-pmu-backlight: Include uapi/linux/fb.h Thierry Reding
2025-10-29 20:27 ` [PATCH 0/2] arch/powerpc: Add missing includes Thomas Zimmermann
2 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2025-10-29 15:09 UTC (permalink / raw)
To: Madhavan Srinivasan, Michael Ellerman
Cc: Nicholas Piggin, Christophe Leroy, Thomas Zimmermann,
linuxppc-dev, linux-kernel
From: Thierry Reding <treding@nvidia.com>
Add the linux/of.h include to make available the standard device tree
functions used by this file.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
arch/powerpc/platforms/powermac/backlight.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/platforms/powermac/backlight.c b/arch/powerpc/platforms/powermac/backlight.c
index 79741370c40c..9afb64723649 100644
--- a/arch/powerpc/platforms/powermac/backlight.c
+++ b/arch/powerpc/platforms/powermac/backlight.c
@@ -14,6 +14,7 @@
#include <linux/pmu.h>
#include <linux/atomic.h>
#include <linux/export.h>
+#include <linux/of.h>
#include <asm/backlight.h>
#define OLD_BACKLIGHT_MAX 15
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] macintosh/via-pmu-backlight: Include uapi/linux/fb.h
2025-10-29 15:09 [PATCH 0/2] arch/powerpc: Add missing includes Thierry Reding
2025-10-29 15:09 ` [PATCH 1/2] arch/powerpc: Add missing linux/of.h include Thierry Reding
@ 2025-10-29 15:09 ` Thierry Reding
2025-10-29 20:27 ` [PATCH 0/2] arch/powerpc: Add missing includes Thomas Zimmermann
2 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2025-10-29 15:09 UTC (permalink / raw)
To: Madhavan Srinivasan, Michael Ellerman
Cc: Nicholas Piggin, Christophe Leroy, Thomas Zimmermann,
linuxppc-dev, linux-kernel
From: Thierry Reding <treding@nvidia.com>
This makes available several of the constants used in this driver.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/macintosh/via-pmu-backlight.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c
index 26bd9ed5e664..aef8930a505b 100644
--- a/drivers/macintosh/via-pmu-backlight.c
+++ b/drivers/macintosh/via-pmu-backlight.c
@@ -13,6 +13,7 @@
#include <linux/backlight.h>
#include <linux/pmu.h>
#include <asm/backlight.h>
+#include <uapi/linux/fb.h>
#define MAX_PMU_LEVEL 0xFF
--
2.51.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] arch/powerpc: Add missing includes
2025-10-29 15:09 [PATCH 0/2] arch/powerpc: Add missing includes Thierry Reding
2025-10-29 15:09 ` [PATCH 1/2] arch/powerpc: Add missing linux/of.h include Thierry Reding
2025-10-29 15:09 ` [PATCH 2/2] macintosh/via-pmu-backlight: Include uapi/linux/fb.h Thierry Reding
@ 2025-10-29 20:27 ` Thomas Zimmermann
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2025-10-29 20:27 UTC (permalink / raw)
To: Thierry Reding, Madhavan Srinivasan, Michael Ellerman
Cc: Nicholas Piggin, Christophe Leroy, linuxppc-dev, linux-kernel
Hi
Am 29.10.25 um 16:09 schrieb Thierry Reding:
> From: Thierry Reding <treding@nvidia.com>
>
> Hi,
>
> I've recently been doing a few test builds for some of the more exotic
> platforms out there for a patch series that I'm working on and ran into
> some issues that seem to have been caused by the framebuffer include
> rework. I see that Thomas did address some of those already, but it
> looks like I've been running with slightly different configurations or
> something that caused these additional ones to come up.
>
> Given that theese seem to have been broken for more than a year and it's
> not exactly clear which commit it caused, I didn't bother adding a Fixes
> line, but still wanted to send these out in case we want to keep these
> platforms building.
>
> Thierry
>
> Thierry Reding (2):
> arch/powerpc: Add missing linux/of.h include
> macintosh/via-pmu-backlight: Include uapi/linux/fb.h
See
https://lore.kernel.org/dri-devel/20251027140646.227025-1-tzimmermann@suse.de/
>
> arch/powerpc/platforms/powermac/backlight.c | 1 +
> drivers/macintosh/via-pmu-backlight.c | 1 +
> 2 files changed, 2 insertions(+)
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-10-29 20:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-29 15:09 [PATCH 0/2] arch/powerpc: Add missing includes Thierry Reding
2025-10-29 15:09 ` [PATCH 1/2] arch/powerpc: Add missing linux/of.h include Thierry Reding
2025-10-29 15:09 ` [PATCH 2/2] macintosh/via-pmu-backlight: Include uapi/linux/fb.h Thierry Reding
2025-10-29 20:27 ` [PATCH 0/2] arch/powerpc: Add missing includes Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox