From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Feng Tang <feng.tang@linux.alibaba.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH v3 5/6] panic: sys_info: Deduplicate local variable 'table; assignments
Date: Thu, 30 Oct 2025 12:44:21 +0100 [thread overview]
Message-ID: <20251030132007.3742368-6-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20251030132007.3742368-1-andriy.shevchenko@linux.intel.com>
The both handlers use the local 'table' variable and assign
the same data to it, deduplicate that.
Reviewed-by: Feng Tang <feng.tang@linux.alibaba.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
lib/sys_info.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/lib/sys_info.c b/lib/sys_info.c
index eb5c1226bfc8..94526de8482b 100644
--- a/lib/sys_info.c
+++ b/lib/sys_info.c
@@ -63,12 +63,13 @@ int sysctl_sys_info_handler(const struct ctl_table *ro_table, int write,
if (!names)
return -ENOMEM;
+ table = *ro_table;
+ table.data = names;
+ table.maxlen = maxlen;
+
if (write) {
int ret;
- table = *ro_table;
- table.data = names;
- table.maxlen = maxlen;
ret = proc_dostring(&table, write, buffer, lenp, ppos);
if (ret)
return ret;
@@ -93,9 +94,6 @@ int sysctl_sys_info_handler(const struct ctl_table *ro_table, int write,
}
}
- table = *ro_table;
- table.data = names;
- table.maxlen = maxlen;
return proc_dostring(&table, write, buffer, lenp, ppos);
}
}
--
2.50.1
next prev parent reply other threads:[~2025-10-30 13:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 11:44 [PATCH v3 0/6] panic: sys_info: Refactor and fix a potential issue Andy Shevchenko
2025-10-30 11:44 ` [PATCH v3 1/6] panic: sys_info: Capture si_bits_global before iterating over it Andy Shevchenko
2025-10-30 11:44 ` [PATCH v3 2/6] panic: sys_info: Align constant definition names with parameters Andy Shevchenko
2025-10-30 11:44 ` [PATCH v3 3/6] panic: sys_info: Replace struct sys_info_name with plain array of strings Andy Shevchenko
2025-10-31 3:06 ` Andrew Morton
2025-10-31 7:23 ` Andy Shevchenko
2025-10-30 11:44 ` [PATCH v3 4/6] panic: sys_info: Rewrite a fix for a compilation error (`make W=1`) Andy Shevchenko
2025-10-30 11:44 ` Andy Shevchenko [this message]
2025-10-30 11:44 ` [PATCH v3 6/6] panic: sys_info: Factor out read and write handlers Andy Shevchenko
2025-10-31 3:16 ` Andrew Morton
2025-10-31 7:22 ` Andy Shevchenko
2025-10-31 7:25 ` Andy Shevchenko
2025-10-30 14:07 ` [PATCH v3 0/6] panic: sys_info: Refactor and fix a potential issue Andy Shevchenko
2025-10-30 15:48 ` Petr Mladek
2025-10-31 7:56 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251030132007.3742368-6-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=feng.tang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox