The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Feng Tang <feng.tang@linux.alibaba.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 6/6] panic: sys_info: Factor out read and write handlers
Date: Fri, 31 Oct 2025 09:22:15 +0200	[thread overview]
Message-ID: <aQRjp4dgn6yWASqC@smile.fi.intel.com> (raw)
In-Reply-To: <20251030201612.8970ca04e861a4f111cc1371@linux-foundation.org>

On Thu, Oct 30, 2025 at 08:16:12PM -0700, Andrew Morton wrote:
> On Thu, 30 Oct 2025 12:44:22 +0100 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

...

> checkpatch wanted this:

Makes sense. Have you applied this update to your tree already? Or should I
send (re-send) a formal patch?

> --- a/lib/sys_info.c~panic-sys_info-factor-out-read-and-write-handlers-checkpatch-fixes
> +++ a/lib/sys_info.c
> @@ -43,7 +43,7 @@ unsigned long sys_info_parse_param(char
>  
>  #ifdef CONFIG_SYSCTL
>  
> -static int sys_info_write_handler(struct ctl_table *table,
> +static int sys_info_write_handler(const struct ctl_table *table,
>  				  void *buffer, size_t *lenp, loff_t *ppos,
>  				  unsigned long *si_bits_global)
>  {
> @@ -62,7 +62,7 @@ static int sys_info_write_handler(struct
>  	return 0;
>  }
>  
> -static int sys_info_read_handler(struct ctl_table *table,
> +static int sys_info_read_handler(const struct ctl_table *table,
>  				 void *buffer, size_t *lenp, loff_t *ppos,
>  				 unsigned long *si_bits_global)
>  {

Thank you for the review!

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-10-31  7:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-30 11:44 [PATCH v3 0/6] panic: sys_info: Refactor and fix a potential issue Andy Shevchenko
2025-10-30 11:44 ` [PATCH v3 1/6] panic: sys_info: Capture si_bits_global before iterating over it Andy Shevchenko
2025-10-30 11:44 ` [PATCH v3 2/6] panic: sys_info: Align constant definition names with parameters Andy Shevchenko
2025-10-30 11:44 ` [PATCH v3 3/6] panic: sys_info: Replace struct sys_info_name with plain array of strings Andy Shevchenko
2025-10-31  3:06   ` Andrew Morton
2025-10-31  7:23     ` Andy Shevchenko
2025-10-30 11:44 ` [PATCH v3 4/6] panic: sys_info: Rewrite a fix for a compilation error (`make W=1`) Andy Shevchenko
2025-10-30 11:44 ` [PATCH v3 5/6] panic: sys_info: Deduplicate local variable 'table; assignments Andy Shevchenko
2025-10-30 11:44 ` [PATCH v3 6/6] panic: sys_info: Factor out read and write handlers Andy Shevchenko
2025-10-31  3:16   ` Andrew Morton
2025-10-31  7:22     ` Andy Shevchenko [this message]
2025-10-31  7:25       ` Andy Shevchenko
2025-10-30 14:07 ` [PATCH v3 0/6] panic: sys_info: Refactor and fix a potential issue Andy Shevchenko
2025-10-30 15:48   ` Petr Mladek
2025-10-31  7:56     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQRjp4dgn6yWASqC@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=feng.tang@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox