From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Sander Vanheule <sander@svanheule.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>
Subject: [PATCH v2 1/5] regcache: Add ->populate() callback to separate from ->init()
Date: Thu, 30 Oct 2025 18:37:01 +0100 [thread overview]
Message-ID: <20251030173915.3886882-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20251030173915.3886882-1-andriy.shevchenko@linux.intel.com>
In the future changes we would like to change the flow of the cache handling.
Add ->populate() callback in order to prepare for that.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/base/regmap/internal.h | 1 +
drivers/base/regmap/regcache.c | 16 ++++++++++++++++
2 files changed, 17 insertions(+)
diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h
index 8d19a1414d5b..1477329410ec 100644
--- a/drivers/base/regmap/internal.h
+++ b/drivers/base/regmap/internal.h
@@ -186,6 +186,7 @@ struct regcache_ops {
enum regcache_type type;
int (*init)(struct regmap *map);
int (*exit)(struct regmap *map);
+ int (*populate)(struct regmap *map);
#ifdef CONFIG_DEBUG_FS
void (*debugfs_init)(struct regmap *map);
#endif
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index 0392f5525cf3..319c342bf5a0 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -222,8 +222,24 @@ int regcache_init(struct regmap *map, const struct regmap_config *config)
if (ret)
goto err_free;
}
+
+ if (map->num_reg_defaults && map->cache_ops->populate) {
+ dev_dbg(map->dev, "Populating %s cache\n", map->cache_ops->name);
+ map->lock(map->lock_arg);
+ ret = map->cache_ops->populate(map);
+ map->unlock(map->lock_arg);
+ if (ret)
+ goto err_exit;
+ }
return 0;
+err_exit:
+ if (map->cache_ops->exit) {
+ dev_dbg(map->dev, "Destroying %s cache\n", map->cache_ops->name);
+ map->lock(map->lock_arg);
+ ret = map->cache_ops->exit(map);
+ map->unlock(map->lock_arg);
+ }
err_free:
kfree(map->reg_defaults);
if (map->cache_free)
--
2.50.1
next prev parent reply other threads:[~2025-10-30 17:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 17:37 [PATCH v2 0/5] regcache: Split out ->populate() and use it Andy Shevchenko
2025-10-30 17:37 ` Andy Shevchenko [this message]
2025-10-30 17:37 ` [PATCH v2 2/5] regcache: rbtree: Split ->populate() from ->init() Andy Shevchenko
2025-10-30 18:05 ` Mark Brown
2025-10-30 19:05 ` Andy Shevchenko
2025-10-31 8:06 ` Andy Shevchenko
2025-10-30 17:37 ` [PATCH v2 3/5] regcache: flat: Remove unneeded check and error message for -ENOMEM Andy Shevchenko
2025-10-30 20:18 ` Sander Vanheule
2025-10-31 8:03 ` Andy Shevchenko
2025-10-30 17:37 ` [PATCH v2 4/5] regcache: flat: Split ->populate() from ->init() Andy Shevchenko
2025-10-30 17:37 ` [PATCH v2 5/5] regcache: maple: " Andy Shevchenko
2025-10-31 14:48 ` [PATCH v2 0/5] regcache: Split out ->populate() and use it Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251030173915.3886882-2-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sander@svanheule.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox