From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sander Vanheule <sander@svanheule.net>
Cc: Mark Brown <broonie@kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>
Subject: Re: [PATCH v2 3/5] regcache: flat: Remove unneeded check and error message for -ENOMEM
Date: Fri, 31 Oct 2025 10:03:45 +0200 [thread overview]
Message-ID: <aQRtYXcltiJwa3lB@smile.fi.intel.com> (raw)
In-Reply-To: <39f251f542baf2148c9e75f94baf0b2188c38e95.camel@svanheule.net>
On Thu, Oct 30, 2025 at 09:18:11PM +0100, Sander Vanheule wrote:
> On Thu, 2025-10-30 at 18:37 +0100, Andy Shevchenko wrote:
> > There is a convention in the kernel to avoid error messages
> > in the cases of -ENOMEM errors. Besides that, the idea behind
> > using struct_size() and other macros from overflow.h is
> > to saturate the size that the following allocation call will
> > definitely fail, hence the check and the error messaging added
> > in regcache_flat_init() are redundant. Remove them.
> Makes sense, although I couldn't find the failure path myself in the code (it's probably
> too deep down in the memory management code). But I see now there are unit tests that
> check allocation failure for overflowed sizes.
>
> FWIW
>
> Acked-by: Sander Vanheule <sander@svanheule.net>
Thanks for looking into this.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-10-31 8:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 17:37 [PATCH v2 0/5] regcache: Split out ->populate() and use it Andy Shevchenko
2025-10-30 17:37 ` [PATCH v2 1/5] regcache: Add ->populate() callback to separate from ->init() Andy Shevchenko
2025-10-30 17:37 ` [PATCH v2 2/5] regcache: rbtree: Split ->populate() " Andy Shevchenko
2025-10-30 18:05 ` Mark Brown
2025-10-30 19:05 ` Andy Shevchenko
2025-10-31 8:06 ` Andy Shevchenko
2025-10-30 17:37 ` [PATCH v2 3/5] regcache: flat: Remove unneeded check and error message for -ENOMEM Andy Shevchenko
2025-10-30 20:18 ` Sander Vanheule
2025-10-31 8:03 ` Andy Shevchenko [this message]
2025-10-30 17:37 ` [PATCH v2 4/5] regcache: flat: Split ->populate() from ->init() Andy Shevchenko
2025-10-30 17:37 ` [PATCH v2 5/5] regcache: maple: " Andy Shevchenko
2025-10-31 14:48 ` [PATCH v2 0/5] regcache: Split out ->populate() and use it Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQRtYXcltiJwa3lB@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sander@svanheule.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox