From: Kyrie Wu <kyrie.wu@mediatek.com>
To: Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Yunfei Dong <yunfei.dong@mediatek.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Kyrie Wu <kyrie.wu@mediatek.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
Nathan Hebert <nhebert@chromium.org>,
"Arnd Bergmann" <arnd@arndb.de>,
Irui Wang <irui.wang@mediatek.com>,
George Sun <george.sun@mediatek.com>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
Yilong Zhou <yilong.zhou@mediatek.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
Subject: [PATCH v5 4/8] media: mediatek: vcodec: Add single core VP9 decoding support for MT8189
Date: Thu, 6 Nov 2025 14:13:19 +0800 [thread overview]
Message-ID: <20251106061323.2193-5-kyrie.wu@mediatek.com> (raw)
In-Reply-To: <20251106061323.2193-1-kyrie.wu@mediatek.com>
1. add config to support 4K prob size;
2. Previously, calling vdec_vp9_slice_setup_single_from_src_to_dst
with v4l2_m2m_next_src_buf to obtain both buffers resulted in -EINVAL,
interrupting the decoding process. To resolve this,
the interface should be updated to set both src and dst buffers
for metadata configuration.
Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
---
.../vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 43 ++++++++++++++-----
1 file changed, 32 insertions(+), 11 deletions(-)
diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
index fa0f406f7726..d966914db4b9 100644
--- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
+++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
@@ -23,6 +23,7 @@
#define VP9_TILE_BUF_SIZE 4096
#define VP9_PROB_BUF_SIZE 2560
+#define VP9_PROB_BUF_4K_SIZE 3840
#define VP9_COUNTS_BUF_SIZE 16384
#define HDR_FLAG(x) (!!((hdr)->flags & V4L2_VP9_FRAME_FLAG_##x))
@@ -542,6 +543,23 @@ static int vdec_vp9_slice_init_default_frame_ctx(struct vdec_vp9_slice_instance
return ret;
}
+static size_t mtk_vcodec_get_vp9_prob_size(enum mtk_vcodec_dec_chip_name chip_name)
+{
+ size_t prob_size;
+
+ switch (chip_name) {
+ case MTK_VDEC_MT8189:
+ case MTK_VDEC_MT8196:
+ prob_size = VP9_PROB_BUF_4K_SIZE;
+ break;
+ default:
+ prob_size = VP9_PROB_BUF_SIZE;
+ break;
+ }
+
+ return prob_size;
+}
+
static int vdec_vp9_slice_alloc_working_buffer(struct vdec_vp9_slice_instance *instance,
struct vdec_vp9_slice_vsi *vsi)
{
@@ -616,7 +634,9 @@ static int vdec_vp9_slice_alloc_working_buffer(struct vdec_vp9_slice_instance *i
}
if (!instance->prob.va) {
- instance->prob.size = VP9_PROB_BUF_SIZE;
+ instance->prob.size =
+ mtk_vcodec_get_vp9_prob_size(ctx->dev->chip_name);
+
if (mtk_vcodec_mem_alloc(ctx, &instance->prob))
goto err;
}
@@ -696,21 +716,22 @@ static int vdec_vp9_slice_tile_offset(int idx, int mi_num, int tile_log2)
return min(offset, mi_num);
}
-static
-int vdec_vp9_slice_setup_single_from_src_to_dst(struct vdec_vp9_slice_instance *instance)
+static int vdec_vp9_slice_setup_single_from_src_to_dst(struct vdec_vp9_slice_instance *instance,
+ struct mtk_vcodec_mem *bs,
+ struct vdec_fb *fb)
{
- struct vb2_v4l2_buffer *src;
- struct vb2_v4l2_buffer *dst;
+ struct mtk_video_dec_buf *src_buf_info;
+ struct mtk_video_dec_buf *dst_buf_info;
- src = v4l2_m2m_next_src_buf(instance->ctx->m2m_ctx);
- if (!src)
+ src_buf_info = container_of(bs, struct mtk_video_dec_buf, bs_buffer);
+ if (!src_buf_info)
return -EINVAL;
- dst = v4l2_m2m_next_dst_buf(instance->ctx->m2m_ctx);
- if (!dst)
+ dst_buf_info = container_of(fb, struct mtk_video_dec_buf, frame_buffer);
+ if (!dst_buf_info)
return -EINVAL;
- v4l2_m2m_buf_copy_metadata(src, dst, true);
+ v4l2_m2m_buf_copy_metadata(&src_buf_info->m2m_buf.vb, &dst_buf_info->m2m_buf.vb, true);
return 0;
}
@@ -1800,7 +1821,7 @@ static int vdec_vp9_slice_setup_single(struct vdec_vp9_slice_instance *instance,
struct vdec_vp9_slice_vsi *vsi = &pfc->vsi;
int ret;
- ret = vdec_vp9_slice_setup_single_from_src_to_dst(instance);
+ ret = vdec_vp9_slice_setup_single_from_src_to_dst(instance, bs, fb);
if (ret)
goto err;
--
2.45.2
next prev parent reply other threads:[~2025-11-06 6:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 6:13 [PATCH v5 0/8] Enable video decoder & encoder for MT8189 Kyrie Wu
2025-11-06 6:13 ` [PATCH v5 1/8] dt-bindings: media: mediatek: decoder: Add MT8189 mediatek,vcodec-decoder Kyrie Wu
2025-11-06 6:13 ` [PATCH v5 2/8] media: mediatek: vcodec: add decoder compatible to support MT8189 Kyrie Wu
2025-11-06 14:21 ` Nicolas Dufresne
2025-11-18 7:22 ` Kyrie Wu (吴晗)
2025-11-06 6:13 ` [PATCH v5 3/8] media: mediatek: vcodec: add profile and level supporting for MT8189 Kyrie Wu
2025-11-06 14:23 ` Nicolas Dufresne
2025-11-06 6:13 ` Kyrie Wu [this message]
2025-11-06 14:29 ` [PATCH v5 4/8] media: mediatek: vcodec: Add single core VP9 decoding support " Nicolas Dufresne
2025-11-17 7:40 ` Kyrie Wu (吴晗)
2025-11-06 6:13 ` [PATCH v5 5/8] media: mediatek: vcodec: fix vp9 4096x2176 fail for profile2 Kyrie Wu
2025-11-06 14:46 ` Nicolas Dufresne
2025-11-17 7:53 ` Kyrie Wu (吴晗)
2025-11-06 15:17 ` Nicolas Dufresne
2025-11-17 7:36 ` Kyrie Wu (吴晗)
2025-11-17 13:50 ` Nicolas Dufresne
2025-11-06 6:13 ` [PATCH v5 6/8] media: mediatek: vcodec: fix media device node number Kyrie Wu
2025-11-06 14:47 ` Nicolas Dufresne
2025-11-17 6:15 ` Kyrie Wu (吴晗)
2025-11-06 6:13 ` [PATCH v5 7/8] dt-bindings: media: Add MT8189 mediatek,vcodec-encoder Kyrie Wu
2025-11-06 6:13 ` [PATCH v5 8/8] media: mediatek: encoder: Add MT8189 encoder compatible data Kyrie Wu
2025-11-06 14:50 ` Nicolas Dufresne
2025-11-17 6:14 ` Kyrie Wu (吴晗)
2025-11-06 14:18 ` [PATCH v5 0/8] Enable video decoder & encoder for MT8189 Nicolas Dufresne
2025-11-10 2:32 ` Kyrie Wu (吴晗)
2025-11-10 13:57 ` Nicolas Dufresne
2025-11-17 6:12 ` Kyrie Wu (吴晗)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106061323.2193-5-kyrie.wu@mediatek.com \
--to=kyrie.wu@mediatek.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=andrzejtp2010@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=george.sun@mediatek.com \
--cc=hverkuil@xs4all.nl \
--cc=irui.wang@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nhebert@chromium.org \
--cc=nicolas.dufresne@collabora.com \
--cc=robh@kernel.org \
--cc=tiffany.lin@mediatek.com \
--cc=yilong.zhou@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox