From: Kyrie Wu <kyrie.wu@mediatek.com>
To: Tiffany Lin <tiffany.lin@mediatek.com>,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Yunfei Dong <yunfei.dong@mediatek.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Kyrie Wu <kyrie.wu@mediatek.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
Nathan Hebert <nhebert@chromium.org>,
"Arnd Bergmann" <arnd@arndb.de>,
Irui Wang <irui.wang@mediatek.com>,
George Sun <george.sun@mediatek.com>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
Yilong Zhou <yilong.zhou@mediatek.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
Subject: [PATCH v5 5/8] media: mediatek: vcodec: fix vp9 4096x2176 fail for profile2
Date: Thu, 6 Nov 2025 14:13:20 +0800 [thread overview]
Message-ID: <20251106061323.2193-6-kyrie.wu@mediatek.com> (raw)
In-Reply-To: <20251106061323.2193-1-kyrie.wu@mediatek.com>
The dram addr of vp9 decoder tile number, which use dram mode
to set tile information, may reach to 36bits for 4096x2176.
It needs to get the highest 4bit of tile buffer address to
set tile buffer address.
Fixes: 5d418351ca8f1 ("media: mediatek: vcodec: support stateless VP9 decoding")
Signed-off-by: Kyrie Wu <kyrie.wu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
index d966914db4b9..91c563c049bd 100644
--- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
+++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c
@@ -1156,7 +1156,10 @@ static int vdec_vp9_slice_setup_tile_buffer(struct vdec_vp9_slice_instance *inst
tiles->size[i][j] = size;
if (tiles->mi_rows[i]) {
*tb++ = (size << 3) + ((offset << 3) & 0x7f);
- *tb++ = pa & ~0xf;
+ *tb = pa & ~0xf;
+ if (IS_ENABLED(CONFIG_ARCH_DMA_ADDR_T_64BIT))
+ *tb |= (pa >> 32) & 0xf;
+ tb++;
*tb++ = (pa << 3) & 0x7f;
mi_row = (tiles->mi_rows[i] - 1) & 0x1ff;
mi_col = (tiles->mi_cols[j] - 1) & 0x3f;
--
2.45.2
next prev parent reply other threads:[~2025-11-06 6:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 6:13 [PATCH v5 0/8] Enable video decoder & encoder for MT8189 Kyrie Wu
2025-11-06 6:13 ` [PATCH v5 1/8] dt-bindings: media: mediatek: decoder: Add MT8189 mediatek,vcodec-decoder Kyrie Wu
2025-11-06 6:13 ` [PATCH v5 2/8] media: mediatek: vcodec: add decoder compatible to support MT8189 Kyrie Wu
2025-11-06 14:21 ` Nicolas Dufresne
2025-11-18 7:22 ` Kyrie Wu (吴晗)
2025-11-06 6:13 ` [PATCH v5 3/8] media: mediatek: vcodec: add profile and level supporting for MT8189 Kyrie Wu
2025-11-06 14:23 ` Nicolas Dufresne
2025-11-06 6:13 ` [PATCH v5 4/8] media: mediatek: vcodec: Add single core VP9 decoding support " Kyrie Wu
2025-11-06 14:29 ` Nicolas Dufresne
2025-11-17 7:40 ` Kyrie Wu (吴晗)
2025-11-06 6:13 ` Kyrie Wu [this message]
2025-11-06 14:46 ` [PATCH v5 5/8] media: mediatek: vcodec: fix vp9 4096x2176 fail for profile2 Nicolas Dufresne
2025-11-17 7:53 ` Kyrie Wu (吴晗)
2025-11-06 15:17 ` Nicolas Dufresne
2025-11-17 7:36 ` Kyrie Wu (吴晗)
2025-11-17 13:50 ` Nicolas Dufresne
2025-11-06 6:13 ` [PATCH v5 6/8] media: mediatek: vcodec: fix media device node number Kyrie Wu
2025-11-06 14:47 ` Nicolas Dufresne
2025-11-17 6:15 ` Kyrie Wu (吴晗)
2025-11-06 6:13 ` [PATCH v5 7/8] dt-bindings: media: Add MT8189 mediatek,vcodec-encoder Kyrie Wu
2025-11-06 6:13 ` [PATCH v5 8/8] media: mediatek: encoder: Add MT8189 encoder compatible data Kyrie Wu
2025-11-06 14:50 ` Nicolas Dufresne
2025-11-17 6:14 ` Kyrie Wu (吴晗)
2025-11-06 14:18 ` [PATCH v5 0/8] Enable video decoder & encoder for MT8189 Nicolas Dufresne
2025-11-10 2:32 ` Kyrie Wu (吴晗)
2025-11-10 13:57 ` Nicolas Dufresne
2025-11-17 6:12 ` Kyrie Wu (吴晗)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106061323.2193-6-kyrie.wu@mediatek.com \
--to=kyrie.wu@mediatek.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=andrzejtp2010@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=george.sun@mediatek.com \
--cc=hverkuil@xs4all.nl \
--cc=irui.wang@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nhebert@chromium.org \
--cc=nicolas.dufresne@collabora.com \
--cc=robh@kernel.org \
--cc=tiffany.lin@mediatek.com \
--cc=yilong.zhou@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox