From: Nathan Chancellor <nathan@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v1 1/1] compiler_types: Warn about unused static inline functions on second
Date: Thu, 6 Nov 2025 10:06:16 -0700 [thread overview]
Message-ID: <20251106170616.GB1693433@ax162> (raw)
In-Reply-To: <aQzGP8Z-mvSS9w7C@smile.fi.intel.com>
On Thu, Nov 06, 2025 at 06:01:03PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 06, 2025 at 08:16:49AM -0700, Nathan Chancellor wrote:
> > and we should
> > probably drop the sentence about removing __inline_maybe_unused entirely
> > since people such as Peter will never want this behavior by default. I
> > do not mind doing it myself if I take it.
>
> But future is uncertain, it might be that GCC also gains this and it won't
> confuse anyway as it might become a truth (no more such warnings in the code)
> at some point.
The reality of the situation is that moving this warning to W=2 is
basically the same as just turning it off entirely since building with
W=2 is not a common endeavor for the majority of folks actually writing
kernel code, so the number of warnings will just continue to grow. At
that point, there is very little reason to believe that we would be able
to go from W=2 to enabled by default at some point in the future since
people already do not like it enabled at W=1 where it is not as
impactful as enabled by default. As a result, I feel like the comment
genuinely serves no purpose. If GCC were to change its behavior to
match clang, I feel like kernel folks would still want the current GCC
behavior.
Cheers,
Nathan
next prev parent reply other threads:[~2025-11-06 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 10:50 [PATCH v1 1/1] compiler_types: Warn about unused static inline functions on second Andy Shevchenko
2025-11-06 15:16 ` Nathan Chancellor
2025-11-06 16:01 ` Andy Shevchenko
2025-11-06 17:06 ` Nathan Chancellor [this message]
2025-11-07 7:45 ` Andy Shevchenko
2025-11-06 19:13 ` Linus Torvalds
2025-11-07 18:29 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106170616.GB1693433@ax162 \
--to=nathan@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox