From: Encrow Thorne <jyc0019@gmail.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Troy Mitchell <troy.mitchell@linux.dev>
Cc: linux-kernel@vger.kernel.org, Encrow Thorne <jyc0019@gmail.com>
Subject: [PATCH v3] reset: fix BIT macro reference
Date: Mon, 10 Nov 2025 14:10:37 +0800 [thread overview]
Message-ID: <20251110-rfc-reset-include-bits-v3-1-39614338fd43@gmail.com> (raw)
RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
include bits.h. This causes compilation errors when including
reset.h standalone.
Include bits.h to make reset.h self-contained.
Suggested-by: Troy Mitchell <troy.mitchell@linux.dev>
Reviewed-by: Troy Mitchell <troy.mitchell@linux.dev>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
---
Changes in v3:
- Fix commit message.
- Link to v2: https://lore.kernel.org/r/20251105-rfc-reset-include-bits-v2-1-f27c57b75a90@gmail.com
Changes in v2:
- Add header in alphabetical order.
- Link to v1: https://lore.kernel.org/r/20251105-rfc-reset-include-bits-v1-1-d7e1bbc7e1ab@gmail.com
---
include/linux/reset.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/reset.h b/include/linux/reset.h
index 840d75d172f6..44f9e3415f92 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -2,6 +2,7 @@
#ifndef _LINUX_RESET_H_
#define _LINUX_RESET_H_
+#include <linux/bits.h>
#include <linux/err.h>
#include <linux/errno.h>
#include <linux/types.h>
---
base-commit: 8fec172c82c2b5f6f8e47ab837c1dc91ee3d1b87
change-id: 20251105-rfc-reset-include-bits-4ec72344d1a3
Best regards,
--
Encrow Thorne <jyc0019@gmail.com>
next reply other threads:[~2025-11-10 6:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 6:10 Encrow Thorne [this message]
2025-11-10 9:03 ` [PATCH v3] reset: fix BIT macro reference Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251110-rfc-reset-include-bits-v3-1-39614338fd43@gmail.com \
--to=jyc0019@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=troy.mitchell@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox