public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] reset: fix BIT macro reference
@ 2025-11-10  6:10 Encrow Thorne
  2025-11-10  9:03 ` Philipp Zabel
  0 siblings, 1 reply; 2+ messages in thread
From: Encrow Thorne @ 2025-11-10  6:10 UTC (permalink / raw)
  To: Philipp Zabel, Troy Mitchell; +Cc: linux-kernel, Encrow Thorne

RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
include bits.h. This causes compilation errors when including
reset.h standalone.

Include bits.h to make reset.h self-contained.

Suggested-by: Troy Mitchell <troy.mitchell@linux.dev>
Reviewed-by: Troy Mitchell <troy.mitchell@linux.dev>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
---
Changes in v3:
- Fix commit message.
- Link to v2: https://lore.kernel.org/r/20251105-rfc-reset-include-bits-v2-1-f27c57b75a90@gmail.com

Changes in v2:
- Add header in alphabetical order.
- Link to v1: https://lore.kernel.org/r/20251105-rfc-reset-include-bits-v1-1-d7e1bbc7e1ab@gmail.com
---
 include/linux/reset.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/reset.h b/include/linux/reset.h
index 840d75d172f6..44f9e3415f92 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -2,6 +2,7 @@
 #ifndef _LINUX_RESET_H_
 #define _LINUX_RESET_H_
 
+#include <linux/bits.h>
 #include <linux/err.h>
 #include <linux/errno.h>
 #include <linux/types.h>

---
base-commit: 8fec172c82c2b5f6f8e47ab837c1dc91ee3d1b87
change-id: 20251105-rfc-reset-include-bits-4ec72344d1a3

Best regards,
-- 
Encrow Thorne <jyc0019@gmail.com>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] reset: fix BIT macro reference
  2025-11-10  6:10 [PATCH v3] reset: fix BIT macro reference Encrow Thorne
@ 2025-11-10  9:03 ` Philipp Zabel
  0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2025-11-10  9:03 UTC (permalink / raw)
  To: Encrow Thorne, Troy Mitchell; +Cc: linux-kernel

On Mo, 2025-11-10 at 14:10 +0800, Encrow Thorne wrote:
> RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
> include bits.h. This causes compilation errors when including
> reset.h standalone.
> 
> Include bits.h to make reset.h self-contained.
> 
> Suggested-by: Troy Mitchell <troy.mitchell@linux.dev>
> Reviewed-by: Troy Mitchell <troy.mitchell@linux.dev>
> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Encrow Thorne <jyc0019@gmail.com>

Applied to reset/next, thanks!

[1/1] reset: fix BIT macro reference
      https://git.pengutronix.de/cgit/pza/linux/commit/?id=dae9b0708255

regards
Philipp

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-10  9:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-10  6:10 [PATCH v3] reset: fix BIT macro reference Encrow Thorne
2025-11-10  9:03 ` Philipp Zabel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox