From: Heiko Carstens <hca@linux.ibm.com>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] s390/ipl: Mark store_status as __noreturn
Date: Mon, 10 Nov 2025 16:06:35 +0100 [thread overview]
Message-ID: <20251110150635.15528B2f-hca@linux.ibm.com> (raw)
In-Reply-To: <20251110132803.1520-1-thorsten.blum@linux.dev>
On Mon, Nov 10, 2025 at 02:27:51PM +0100, Thorsten Blum wrote:
> store_status() performs a tail call (BR_EX) to the function passed as
> the first parameter and does not return. Annotate the declaration with
> the __noreturn attribute to improve compiler optimizations.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> arch/s390/include/asm/ipl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This doesn't make any sense. If a function is called, which calls
another one with a tail call, then _of course_ it looks to the caller
like the function returned.
next prev parent reply other threads:[~2025-11-10 15:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 13:27 [PATCH 1/5] s390/ipl: Mark store_status as __noreturn Thorsten Blum
2025-11-10 13:27 ` [PATCH 2/5] s390/kdump: Mark __machine_kdump " Thorsten Blum
2025-11-10 13:27 ` [PATCH 3/5] s390/kdump: Mark __do_machine_kexec " Thorsten Blum
2025-11-10 13:27 ` [PATCH 4/5] s390/kdump: Mark __machine_kexec " Thorsten Blum
2025-11-10 13:27 ` [PATCH 5/5] s390/kdump: Mark __do_machine_kdump " Thorsten Blum
2025-11-10 15:06 ` Heiko Carstens [this message]
2025-11-11 7:00 ` [PATCH 1/5] s390/ipl: Mark store_status " Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251110150635.15528B2f-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox