[PATCH] drm/sched: Fix outdated sched_job docu

[PATCH] drm/sched: Fix outdated sched_job docu

[Philipp Stanner]

There is no such thing as a "done_list" anymore. Remove mention of it.

Signed-off-by: Philipp Stanner <phasta@kernel.org>
---
 include/drm/gpu_scheduler.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
index fb88301b3c45..18d6210ce2d0 100644
--- a/include/drm/gpu_scheduler.h
+++ b/include/drm/gpu_scheduler.h
@@ -320,7 +320,7 @@ struct drm_sched_fence *to_drm_sched_fence(struct dma_fence *f);
  * struct drm_sched_job - A job to be run by an entity.
  *
  * @queue_node: used to append this struct to the queue of jobs in an entity.
- * @list: a job participates in a "pending" and "done" lists.
+ * @list: for enqueueing the job into the list of pending jobs.
  * @sched: the scheduler instance on which this job is scheduled.
  * @s_fence: contains the fences for the scheduling of job.
  * @finish_cb: the callback for the finished fence.
-- 
2.49.0

Re: [PATCH] drm/sched: Fix outdated sched_job docu

[Tvrtko Ursulin]

On 11/11/2025 16:15, Philipp Stanner wrote:
> There is no such thing as a "done_list" anymore. Remove mention of it.
> 
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
> ---
>   include/drm/gpu_scheduler.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
> index fb88301b3c45..18d6210ce2d0 100644
> --- a/include/drm/gpu_scheduler.h
> +++ b/include/drm/gpu_scheduler.h
> @@ -320,7 +320,7 @@ struct drm_sched_fence *to_drm_sched_fence(struct dma_fence *f);
>    * struct drm_sched_job - A job to be run by an entity.
>    *
>    * @queue_node: used to append this struct to the queue of jobs in an entity.
> - * @list: a job participates in a "pending" and "done" lists.
> + * @list: for enqueueing the job into the list of pending jobs.
>    * @sched: the scheduler instance on which this job is scheduled.
>    * @s_fence: contains the fences for the scheduling of job.
>    * @finish_cb: the callback for the finished fence.

Interesting that I cannot see there was a done list at the time when 
that comment was added. Anyway, I did not dig much further back since 
for the current state the correction is obviously correct.

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>

Regards,

Tvrtko