From: Tiffany Yang <ynaffit@google.com>
To: linux-kernel@vger.kernel.org
Cc: kernel-team@android.com, Andy Whitcroft <apw@canonical.com>,
Joe Perches <joe@perches.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: [PATCH 1/3] checkpatch: handle variables that begin with 'case'
Date: Fri, 14 Nov 2025 15:31:51 -0800 [thread overview]
Message-ID: <20251114233150.396974-4-ynaffit@google.com> (raw)
The current script returns switch statement-related errors when
variables that start with "case" are used in a ternary.
For example:
./scripts/checkpatch.pl --git d1934ed9803c
ERROR: space prohibited before that ':' (ctx:WxW)
#289: FILE: drivers/android/tests/binder_alloc_kunit.c:321:
+ case_failed ? "FAILED" : "PASSED",
^
ERROR: trailing statements should be on next line
#289: FILE: drivers/android/tests/binder_alloc_kunit.c:321:
+ case_failed ? "FAILED" : "PASSED",
Fix these false positives.
Signed-off-by: Tiffany Yang <ynaffit@google.com>
---
scripts/checkpatch.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 92669904eecc..b026b1235079 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2179,7 +2179,7 @@ sub annotate_values {
$av_pending = 'E';
$type = 'N';
- } elsif ($cur =~/^(case)/o) {
+ } elsif ($cur =~/^(case)\b/o) {
print "CASE($1)\n" if ($dbg_values > 1);
$av_pend_colon = 'C';
$type = 'N';
@@ -5797,7 +5797,7 @@ sub process {
$herecurr);
}
# case and default should not have general statements after them
- if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
+ if ($line =~ /^.\s*(?:case\b\s*.*|default\s*):/g &&
$line !~ /\G(?:
(?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$|
\s*return\s+
--
2.52.0.rc1.455.g30608eb744-goog
next reply other threads:[~2025-11-14 23:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 23:31 Tiffany Yang [this message]
2025-11-14 23:31 ` [PATCH 2/3] checkpatch: check indentation on case without space Tiffany Yang
2025-11-14 23:31 ` [PATCH] checkpatch: Allow bare SHA-1 hashes in checkpatch commits Tiffany Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251114233150.396974-4-ynaffit@google.com \
--to=ynaffit@google.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox